linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH V3 0/4] zram: fix two races and one zram leak
Date: Mon, 1 Nov 2021 08:28:13 +0800	[thread overview]
Message-ID: <YX80nS0ypqCytdwC@T590> (raw)
In-Reply-To: <YXbbj7KhgAkgByp1@google.com>

Hello Andrew Morton and Jens,

On Mon, Oct 25, 2021 at 09:30:07AM -0700, Minchan Kim wrote:
> On Mon, Oct 25, 2021 at 10:54:22AM +0800, Ming Lei wrote:
> > Hello,
> > 
> > Fixes three issues reported by Luis Chamberlain with one simpler approach:
> > 
> > - race between between zram_reset_device() and disksize_store() (1/4)
> > 
> > - zram leak during unloading module, which is one race between resetting
> > and removing device (2/4)
> > 
> > - race between zram_remove and disksize_store (3/4)
> > 
> > Also replace replace fsync_bdev with sync_blockdev since no one opens
> > it.(4/4)
> > 
> > V3:
> > 	- no code change
> > 	- update commit log or comment as Luis suggested
> > 	- add reviewed-by tag
> > 
> > V2:
> > 	- take another approach to avoid failing of zram_remove()
> > 	- add patch to address race between zram_reset_device() and
> > 	  disksize_store()
> > 
> > 
> > Ming Lei (4):
> >   zram: fix race between zram_reset_device() and disksize_store()
> >   zram: don't fail to remove zram during unloading module
> >   zram: avoid race between zram_remove and disksize_store
> >   zram: replace fsync_bdev with sync_blockdev
> 
> Andrew Morton usually takes zram patches so Ccing him.
> 
> Acked-by: Minchan Kim <minchan@kernel.org>
> 
> for all patches in this thread.
 
Any chance to make it in v5.16?

Thanks,
Ming


  reply	other threads:[~2021-11-01  0:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25  2:54 [PATCH V3 0/4] zram: fix two races and one zram leak Ming Lei
2021-10-25  2:54 ` [PATCH V3 1/4] zram: fix race between zram_reset_device() and disksize_store() Ming Lei
2021-10-25  2:54 ` [PATCH V3 2/4] zram: don't fail to remove zram during unloading module Ming Lei
2021-10-25  2:54 ` [PATCH V3 3/4] zram: avoid race between zram_remove and disksize_store Ming Lei
2021-10-25  2:54 ` [PATCH V3 4/4] zram: replace fsync_bdev with sync_blockdev Ming Lei
2021-10-25 16:30 ` [PATCH V3 0/4] zram: fix two races and one zram leak Minchan Kim
2021-11-01  0:28   ` Ming Lei [this message]
2021-11-02 20:43 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YX80nS0ypqCytdwC@T590 \
    --to=ming.lei@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).