From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5B2C433EF for ; Fri, 22 Oct 2021 17:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8FDE61108 for ; Fri, 22 Oct 2021 17:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233648AbhJVRef (ORCPT ); Fri, 22 Oct 2021 13:34:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233841AbhJVReb (ORCPT ); Fri, 22 Oct 2021 13:34:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D848C061764; Fri, 22 Oct 2021 10:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OKfvrtFBtwiA0Tu1YZOuL3nfKQ8sUH+Zr1oqgjSXc7U=; b=qgxFVFnAlJpx/3AvC78PBLsO+a gq0T00ja3TFC1ADNr09ydJyjAn4ilFNCIxx+RnqYbBPnTYbE14D0Zgqugqu1N5wCZBjMkZ4dLHt/e JkHp9qih5Zmyqc8HBGY7+wGOJ5S56FAbO/sZTDdXPy5dQ9WNCAws4MHzMLXEF5tZaOve6uz8dhXo0 ciQEQ0JUP0HBGqz+JK4Lk1znRAD7TLcvhQhum0oApHaXdp9ilGoBRUVMJCYJEKL6v06PZbDsFTp8H 6Md/gW0LH/dxz8EQyEe/wJUm7blMlEqGjmJZ1yj1fsxDBHTyH/JR3g2Kt7W0sk4XNNPWBYRy3tJca RUvITziw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdyOq-00Bdow-3J; Fri, 22 Oct 2021 17:32:12 +0000 Date: Fri, 22 Oct 2021 10:32:12 -0700 From: Luis Chamberlain To: Tetsuo Handa Cc: schmitzmic@gmail.com, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de, efremov@linux.com, song@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, hare@suse.de, jack@suse.cz, ming.lei@redhat.com, tj@kernel.org Subject: Re: [PATCH v3 0/3] last batch of add_disk() error handling conversions Message-ID: References: <20211021163856.2000993-1-mcgrof@kernel.org> <66655777-6f9b-adbc-03ff-125aecd3f509@i-love.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Oct 22, 2021 at 10:08:39AM -0700, Luis Chamberlain wrote: > On Fri, Oct 22, 2021 at 10:06:07AM +0900, Tetsuo Handa wrote: > > On 2021/10/22 1:38, Luis Chamberlain wrote: > > > I rebased Tetsuo Handa's patch onto the latest linux-next as this > > > series depends on it, and so I am sending it part of this series as > > > without it, this won't apply. Tetsuo, does the rebase of your patch > > > look OK? > > > > OK, though I wanted my fix to be sent to upstream and stable before this series. > > Sure, absolutely, your patch is certainly separate and is needed as a > fix downstream to stable it would seem. > > > > If it is not too much trouble, I'd like to ask for testing for the > > > ataflop changes from Michael Schmitz, if possible, that is he'd just > > > have to merge Tetsuo's rebased patch and the 2nd patch in this series. > > > This is all rebased on linux-next tag 20211020. > > > > Yes, please. > > > > After this series, I guess we can remove "bool registered[NUM_DISK_MINORS];" like below > > due to (unit[drive].disk[type] != NULL) == (unit[drive].registered[type] == true). > > Sounds good. > > > Regarding this series, setting unit[drive].registered[type] = true in ataflop_probe() is > > pointless because atari_floppy_cleanup() checks unit[i].disk[type] != NULL for calling > > del_gendisk(). > > I see, will fix. Actually just not doing it for that case seems odd, so I would prefer the removal of the bool registered to be a separate patch to make it clearer. Luis