From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DE2C433F5 for ; Tue, 9 Nov 2021 03:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6F796117A for ; Tue, 9 Nov 2021 03:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238763AbhKIDI3 (ORCPT ); Mon, 8 Nov 2021 22:08:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38839 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238738AbhKIDI3 (ORCPT ); Mon, 8 Nov 2021 22:08:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636427143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4/DB+ecIvLm4RLKgaYYMmfgFiKR820I9FT3zdqxU7+I=; b=TD7N1L7a8xZjwazhAJ6btHr+Ss8v/a3QZYCx8bxUwzWTQXqUhGgYjMO43WJOBLGs2FufBb CwbWnUasxBhoHbSd7kQDIGPXzU9bX/W27VhRxlhPBhVS1fCSykSvY07nCQn56Z44J+q4gv cPOFO4FWsBXhGhqhWpe/dKWxSSEjdxE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-jhfvtLSlOle-2Ns3e-_pxw-1; Mon, 08 Nov 2021 22:05:42 -0500 X-MC-Unique: jhfvtLSlOle-2Ns3e-_pxw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2DCEA19057A4; Tue, 9 Nov 2021 03:05:41 +0000 (UTC) Received: from T590 (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24380101E594; Tue, 9 Nov 2021 03:05:06 +0000 (UTC) Date: Tue, 9 Nov 2021 11:05:02 +0800 From: Ming Lei To: John Garry Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kashyap.desai@broadcom.com, hare@suse.de Subject: Re: [PATCH RFT 2/3] blk-mq: Delete busy_iter_fn Message-ID: References: <1635852455-39935-1-git-send-email-john.garry@huawei.com> <1635852455-39935-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635852455-39935-3-git-send-email-john.garry@huawei.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Nov 02, 2021 at 07:27:34PM +0800, John Garry wrote: > Typedefs busy_iter_fn and busy_tag_iter_fn are now identical, so delete > busy_iter_fn to reduce duplication. > > It would be nicer to delete busy_tag_iter_fn, as the name busy_iter_fn is > less specific. > > However busy_tag_iter_fn is used in many different parts of the tree, > unlike busy_iter_fn which is just use in block/, so just take the > straightforward path now, so that we could rename later treewide. > > Signed-off-by: John Garry Reviewed-by: Ming Lei -- Ming