linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	willy@infradead.org, axboe@kernel.dk
Subject: Re: [PATCH 2/2] block: Rework bio_for_each_folio_all()
Date: Mon, 3 Apr 2023 11:51:24 -0400	[thread overview]
Message-ID: <ZCr1/K03uGF3neCY@moria.home.lan> (raw)
In-Reply-To: <ZCrtEWEYGdGN++wX@infradead.org>

On Mon, Apr 03, 2023 at 08:13:21AM -0700, Christoph Hellwig wrote:
> On Mon, Mar 27, 2023 at 01:44:02PM -0400, Kent Overstreet wrote:
> > +	bio_for_each_folio_all(fv, bio, iter)
> > +		iomap_finish_folio_read(fv.fv_folio, fv.fv_offset, fv.fv_len, error);
> 
> Please avoid the overly long lines.  Also if we pass all arguments
> of the folio_vec we might as ell just pass that folio_vec anyway.
> 
> > -	BUG_ON(iter->idx > bio->bi_vcnt || (iter->idx == bio->bi_vcnt && iter->done));
> > +	BUG_ON(iter->idx > bio->bi_vcnt ||
> > +	       (iter->idx == bio->bi_vcnt && iter->done));
> 
> Seems like this should be folded into the previous patch.  Also I
> generally prefer to avoid top-level || in asserts and just do multiple
> asserts, as that shows which condition triggered.

It should be folded in, but it's logically the same assert (advance
past the end of the iter) so not worth the increased code size.

  reply	other threads:[~2023-04-03 15:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 17:44 [PATCH 0/2] bio iter improvements Kent Overstreet
2023-03-27 17:44 ` [PATCH 1/2] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-03-29 16:50   ` Phillip Lougher
2023-03-30 17:55     ` Kent Overstreet
2023-03-30 18:59       ` Phillip Lougher
2023-03-31  1:10         ` Phillip Lougher
2023-04-01  2:28           ` Kent Overstreet
2023-04-03 13:57             ` Phillip Lougher
2023-03-30 11:49   ` Ming Lei
2023-03-30 16:20     ` Kent Overstreet
2023-03-27 17:44 ` [PATCH 2/2] block: Rework bio_for_each_folio_all() Kent Overstreet
2023-04-03 15:13   ` Christoph Hellwig
2023-04-03 15:51     ` Kent Overstreet [this message]
2023-03-27 22:14 ` [PATCH 0/2] bio iter improvements Christoph Hellwig
2023-03-28 20:28   ` Kent Overstreet
2023-04-03 15:10     ` Christoph Hellwig
2023-04-03 16:36       ` Kent Overstreet
2023-04-04 15:20         ` Christoph Hellwig
2023-04-04 15:47           ` Kent Overstreet
2023-04-04 15:59             ` Christoph Hellwig
2023-04-04 16:08               ` Kent Overstreet
2023-04-04 16:01             ` Jens Axboe
2023-04-04 16:06               ` Kent Overstreet
2023-04-04 16:14                 ` Jens Axboe
2023-04-04 17:11                   ` Kent Overstreet
2023-03-28 13:42 ` Phillip Lougher
2023-03-28 16:57   ` Kent Overstreet
2023-03-29 16:41     ` Phillip Lougher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCr1/K03uGF3neCY@moria.home.lan \
    --to=kent.overstreet@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).