From: Pavel Begunkov <asml.silence@gmail.com>
To: Hou Tao <houtao1@huawei.com>,
axboe@kernel.dk, linux-block@vger.kernel.org
Cc: osandov@fb.com, ming.lei@redhat.com
Subject: Re: [PATCH 1/2] block: make rq sector size accessible for block stats
Date: Sun, 15 Sep 2019 19:52:59 +0300 [thread overview]
Message-ID: <a23faff8-1d82-a101-dc27-d6e540b68c23@gmail.com> (raw)
In-Reply-To: <20190521075904.135060-2-houtao1@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 1042 bytes --]
Hi,
Works well for me
Tested-by: Pavel Begunkov <asml.silence@gmail.com>
Yet, take a look at the comment below.
By the way,
Fixes: 795fe54c2a828099e ("block: move blk_stat_add() to
__blk_mq_end_request()")
On 21/05/2019 10:59, Hou Tao wrote:
> +++ b/include/linux/blkdev.h
> @@ -202,9 +202,12 @@ struct request {
> #ifdef CONFIG_BLK_WBT
> unsigned short wbt_flags;
> #endif
> -#ifdef CONFIG_BLK_DEV_THROTTLING_LOW
> - unsigned short throtl_size;
> -#endif
> + /*
> + * rq sectors used for blk stats. It has the same value
> + * with blk_rq_sectors(rq), except that it never be zeroed
> + * by completion.
> + */
> + unsigned short stats_sectors;
It can handle max 32MiB. Can a request's data be larger than that?
>
> /*
> * Number of scatter-gather DMA addr+len pairs after
> @@ -892,6 +895,7 @@ static inline struct request_queue *bdev_get_queue(struct block_device *bdev)
> * blk_rq_err_bytes() : bytes left till the next error boundary
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-15 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 7:59 [PATCH 0/2] fixes for block stats Hou Tao
2019-05-21 7:59 ` [PATCH 1/2] block: make rq sector size accessible " Hou Tao
2019-05-25 11:46 ` Pavel Begunkov
2019-05-25 13:52 ` Pavel Begunkov
2019-05-27 11:39 ` Hou Tao
2019-05-28 18:25 ` Pavel Begunkov
2019-09-15 16:52 ` Pavel Begunkov [this message]
2019-05-21 7:59 ` [PATCH 2/2] block: also check RQF_STATS in blk_mq_need_time_stamp() Hou Tao
2019-05-25 5:12 ` [PATCH 0/2] fixes for block stats Hou Tao
2019-09-15 22:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a23faff8-1d82-a101-dc27-d6e540b68c23@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).