From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9C8C3F68F for ; Wed, 18 Dec 2019 21:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DEF82072B for ; Wed, 18 Dec 2019 21:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbfLRVLa (ORCPT ); Wed, 18 Dec 2019 16:11:30 -0500 Received: from imap2.colo.codethink.co.uk ([78.40.148.184]:41368 "EHLO imap2.colo.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfLRVLa (ORCPT ); Wed, 18 Dec 2019 16:11:30 -0500 Received: from [167.98.27.226] (helo=xylophone) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1ihgbL-0002sO-Fs; Wed, 18 Dec 2019 21:11:23 +0000 Message-ID: Subject: Re: [PATCH v2 23/27] compat_ioctl: move HDIO ioctl handling into drivers/ide From: Ben Hutchings To: Arnd Bergmann , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-doc@vger.kernel.org, corbet@lwn.net, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Date: Wed, 18 Dec 2019 21:11:22 +0000 In-Reply-To: <20191217221708.3730997-24-arnd@arndb.de> References: <20191217221708.3730997-1-arnd@arndb.de> <20191217221708.3730997-24-arnd@arndb.de> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, 2019-12-17 at 23:17 +0100, Arnd Bergmann wrote: > Most of the HDIO ioctls are only used by the obsolete drivers/ide > subsystem, these can be handled by changing ide_cmd_ioctl() to be aware > of compat mode and doing the correct transformations in place and using > it as both native and compat handlers for all drivers. > > The SCSI drivers implementing the same commands are already doing > this in the drivers, so the compat_blkdev_driver_ioctl() function > is no longer needed now. > > The BLKSECTSET and HDIO_GETGEO_BIG ioctls are not implemented > in any driver any more and no longer need any conversion. [...] I noticed that HDIO_DRIVE_TASKFILE, handled by ide_taskfile_ioctl() in drivers/ide/ide-taskfile.c, never had compat handling before. After this patch it does, but its argument isn't passed through compat_ptr(). Again, doesn't really matter because IDE isn't a thing on s390. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom