From: Jens Axboe <axboe@kernel.dk>
To: Aleix Roca Nonell <aleix.rocanonell@bsc.es>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix manual setup of iov_iter for fixed buffers
Date: Thu, 15 Aug 2019 11:22:09 -0600 [thread overview]
Message-ID: <ab327769-f18d-61d4-1c71-fb7ad60bb53d@kernel.dk> (raw)
In-Reply-To: <20190815120322.GA19630@rocks>
On 8/15/19 6:03 AM, Aleix Roca Nonell wrote:
> Commit bd11b3a391e3 ("io_uring: don't use iov_iter_advance() for fixed
> buffers") introduced an optimization to avoid using the slow
> iov_iter_advance by manually populating the iov_iter iterator in some
> cases.
>
> However, the computation of the iterator count field was erroneous: The
> first bvec was always accounted for an extent of page size even if the
> bvec length was smaller.
>
> In consequence, some I/O operations on fixed buffers were unable to
> operate on the full extent of the buffer, consistently skipping some
> bytes at the end of it.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-08-15 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:03 [PATCH] io_uring: fix manual setup of iov_iter for fixed buffers Aleix Roca Nonell
2019-08-15 17:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab327769-f18d-61d4-1c71-fb7ad60bb53d@kernel.dk \
--to=axboe@kernel.dk \
--cc=aleix.rocanonell@bsc.es \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).