From: Jens Axboe <axboe@kernel.dk>
To: Mike Christie <mchristi@redhat.com>,
nbd@other.debian.org, rjones@redhat.com, ebiggers@kernel.org,
josef@toxicpanda.com, linux-block@vger.kernel.org
Cc: syzbot+24c12fa8d218ed26011a@syzkaller.appspotmail.com
Subject: Re: [PATCH] nbd: verify socket is supported during setup
Date: Fri, 25 Oct 2019 14:37:35 -0600 [thread overview]
Message-ID: <abf05db4-03ce-43a1-396c-a366b1d46451@kernel.dk> (raw)
In-Reply-To: <20191017212734.10778-1-mchristi@redhat.com>
On 10/17/19 3:27 PM, Mike Christie wrote:
> nbd requires socket families to support the shutdown method so the nbd
> recv workqueue can be woken up from its sock_recvmsg call. If the socket
> does not support the callout we will leave recv works running or get hangs
> later when the device or module is removed.
>
> This adds a check during socket connection/reconnection to make sure the
> socket being passed in supports the needed callout.
Applied, thanks Mike.
--
Jens Axboe
prev parent reply other threads:[~2019-10-25 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:27 [PATCH] nbd: verify socket is supported during setup Mike Christie
2019-10-18 8:01 ` Richard W.M. Jones
2019-10-25 20:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf05db4-03ce-43a1-396c-a366b1d46451@kernel.dk \
--to=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nbd@other.debian.org \
--cc=rjones@redhat.com \
--cc=syzbot+24c12fa8d218ed26011a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).