From: Steffen Maier <maier@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Khalid Aziz <khalid@gonehiking.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Hannes Reinecke <hare@suse.com>,
Ondrej Zary <linux@rainbow-software.org>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
Benjamin Block <bblock@linux.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH 5/8] scsi: remove the unchecked_isa_dma flag
Date: Mon, 12 Apr 2021 16:04:07 +0200 [thread overview]
Message-ID: <ad37abab-6a23-bd44-f2d7-47dde4a21ac3@linux.ibm.com> (raw)
In-Reply-To: <20210410065231.GA16173@lst.de>
On 4/10/21 8:52 AM, Christoph Hellwig wrote:
> On Fri, Apr 09, 2021 at 05:46:09PM +0200, Steffen Maier wrote:
>> Is it OK to remove a long standing sysfs attribute?
>> Was there any deprecation phase?
>>
>> I just noticed it in our CI reporting fails due to this change since at
>> least linux-next 20210409. Suppose it came via
>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.13/block&id=aaff5ebaa2694f283b7d07fdd55fb287ffc4f1e9
>>
>> Wanted to ask before I adapt the test cases.
>
> What does your CI do with it?
We check almost all zfcp-related sysfs attributes for returning expected values
(depending on possible error inject state transitions as well as steady state).
The Scsi_Host's unchecked_isa_dma is just checked to return '0'.
> It would be kinda of sad to carry around this baggage, but if real
> userspace is broken by the chance we'll have to do it. I'm just not
> entirely sure testcases qualify as real userspace yet.
I was more pondering whether sysfs is considered stable API.
I'm not aware of any issues with real userspace if unchecked_isa_dma is absent.
Have adapted our test case to accept a missing unchecked_isa_dma sysfs attribute.
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2021-04-12 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 7:29 start removing block bounce buffering support v3 Christoph Hellwig
2021-03-31 7:29 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-31 7:29 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-31 18:24 ` Khalid Aziz
2021-04-03 16:58 ` Maciej W. Rozycki
2021-04-06 6:27 ` Christoph Hellwig
2021-04-06 15:42 ` Maciej W. Rozycki
2021-04-12 12:26 ` Maciej W. Rozycki
2021-03-31 7:29 ` [PATCH 3/8] BusLogic: reject broken old firmware that requires ISA-style bounce buffering Christoph Hellwig
2021-03-31 7:29 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-31 7:59 ` Hannes Reinecke
2021-03-31 7:29 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-04-09 15:46 ` Steffen Maier
2021-04-10 6:52 ` Christoph Hellwig
2021-04-12 14:04 ` Steffen Maier [this message]
2021-03-31 7:29 ` [PATCH 6/8] block: remove BLK_BOUNCE_ISA support Christoph Hellwig
2021-03-31 7:30 ` [PATCH 7/8] block: refactor the bounce buffering code Christoph Hellwig
2021-03-31 7:30 ` [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests Christoph Hellwig
2021-04-08 21:45 ` Guenter Roeck
2021-04-09 7:40 ` Christoph Hellwig
2021-04-09 13:04 ` Guenter Roeck
2021-04-06 15:28 ` start removing block bounce buffering support v3 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 5:58 start removing block bounce buffering support v2 Christoph Hellwig
2021-03-26 5:58 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-29 6:31 ` Hannes Reinecke
2021-03-18 6:39 start removing block bounce buffering support Christoph Hellwig
2021-03-18 6:39 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad37abab-6a23-bd44-f2d7-47dde4a21ac3@linux.ibm.com \
--to=maier@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=bblock@linux.ibm.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=khalid@gonehiking.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).