From: Jens Axboe <axboe@kernel.dk>
To: Dmitrii Dolgov <9erthalion6@gmail.com>, linux-block@vger.kernel.org
Subject: Re: [RFC v3] io_uring: add set of tracing events
Date: Thu, 17 Oct 2019 17:28:23 -0600 [thread overview]
Message-ID: <af0fc0a7-11cc-08e6-cdfd-6b55fc208c8f@kernel.dk> (raw)
In-Reply-To: <20191015170201.27131-1-9erthalion6@gmail.com>
On 10/15/19 11:02 AM, Dmitrii Dolgov wrote:
> To trace io_uring activity one can get an information from workqueue and
> io trace events, but looks like some parts could be hard to identify via
> this approach. Making what happens inside io_uring more transparent is
> important to be able to reason about many aspects of it, hence introduce
> the set of tracing events.
>
> All such events could be roughly divided into two categories:
>
> * those, that are helping to understand correctness (from both kernel
> and an application point of view). E.g. a ring creation, file
> registration, or waiting for available CQE. Proposed approach is to
> get a pointer to an original structure of interest (ring context, or
> request), and then find relevant events. io_uring_queue_async_work
> also exposes a pointer to work_struct, to be able to track down
> corresponding workqueue events.
>
> * those, that provide performance related information. Mostly it's about
> events that change the flow of requests, e.g. whether an async work
> was queued, or delayed due to some dependencies. Another important
> case is how io_uring optimizations (e.g. registered files) are
> utilized.
Looks good to me, I've applied it for some testing. Thanks!
--
Jens Axboe
next prev parent reply other threads:[~2019-10-17 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 17:02 [RFC v3] io_uring: add set of tracing events Dmitrii Dolgov
2019-10-17 23:28 ` Jens Axboe [this message]
2019-10-18 8:59 ` Dmitry Dolgov
2019-10-18 14:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0fc0a7-11cc-08e6-cdfd-6b55fc208c8f@kernel.dk \
--to=axboe@kernel.dk \
--cc=9erthalion6@gmail.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).