From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0CAC4CEC6 for ; Thu, 12 Sep 2019 22:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AA0D20856 for ; Thu, 12 Sep 2019 22:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfILWJY (ORCPT ); Thu, 12 Sep 2019 18:09:24 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48546 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfILWJY (ORCPT ); Thu, 12 Sep 2019 18:09:24 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tonyk) with ESMTPSA id 5C3A728A2EC Subject: Re: [PATCH 2/3] null_blk: fix module name at log message To: Jens Axboe , Ezequiel Garcia , linux-block@vger.kernel.org, linux-doc@vger.kernel.org Cc: corbet@lwn.net, m@bjorling.me, kernel@collabora.com, krisman@collabora.com References: <20190911144636.226945-1-andrealmeid@collabora.com> <20190911144636.226945-2-andrealmeid@collabora.com> <943a2fc3-4812-cc41-bdff-be13ec319257@kernel.dk> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: Date: Thu, 12 Sep 2019 19:08:15 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <943a2fc3-4812-cc41-bdff-be13ec319257@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/12/19 5:47 PM, Jens Axboe wrote: > On 9/12/19 9:47 AM, Ezequiel Garcia wrote: >> Hi André, Jens, >> >> On Wed, 2019-09-11 at 11:46 -0300, André Almeida wrote: >>> The name of the module is "null_blk", not "null". Make `pr_info()` follow >>> the pattern of `pr_err()` log messages. >>> >> >> Instead of doing these fixes manually, it's more consistent and smarter >> to use pr_fmt. There are many examples of drivers doing that. >> >> I don't know if this patch can be dropped, and replaced with one used pr_fmt >> or if doesn't worth the trouble. >> >> It would be even better to also patch Documentation/process/coding-style.rst, >> in particular the printing section, making a mention to pr_fmt. > > André, please address the comments in this email and from Willy. Note > that the previous patch is queued up, so you'll need to make it relative > to that. > Ok Jens, I'll do it.