From: Jens Axboe <axboe@kernel.dk>
To: "Chaitanya Kulkarni" <Chaitanya.Kulkarni@wdc.com>,
"Matthew Wilcox" <willy@infradead.org>,
"André Almeida" <andrealmeid@collabora.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"m@bjorling.me" <m@bjorling.me>,
"kernel@collabora.com" <kernel@collabora.com>,
"krisman@collabora.com" <krisman@collabora.com>
Subject: Re: [PATCH 3/3] null_blk: validated the number of devices
Date: Fri, 13 Sep 2019 10:48:24 -0600 [thread overview]
Message-ID: <bb344ee1-b7f1-9029-b9c1-177193371b35@kernel.dk> (raw)
In-Reply-To: <BYAPR04MB5749E8298AEBE080BFD3F26A86B30@BYAPR04MB5749.namprd04.prod.outlook.com>
On 9/13/19 10:27 AM, Chaitanya Kulkarni wrote:
> On 09/13/2019 09:23 AM, Jens Axboe wrote:
>> It also breaks the case of loading it, then setting up a new device
>> through configfs.
>
> Yep, this is exactly I was asking nr_device=0 as modparam is allowed
> and membacked null_blk creation will fail with this check.
>
Yeah, it's totally broken...
--
Jens Axboe
next prev parent reply other threads:[~2019-09-13 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:46 [PATCH 1/3] docs: block: null_blk: enhance document style André Almeida
2019-09-11 14:46 ` [PATCH 2/3] null_blk: fix module name at log message André Almeida
2019-09-12 15:47 ` Ezequiel Garcia
2019-09-12 20:47 ` Jens Axboe
2019-09-12 22:08 ` André Almeida
2019-09-11 14:46 ` [PATCH 3/3] null_blk: validated the number of devices André Almeida
2019-09-12 16:19 ` Matthew Wilcox
2019-09-12 22:07 ` André Almeida
2019-09-12 22:20 ` Chaitanya Kulkarni
2019-09-13 14:57 ` André Almeida
2019-09-13 15:12 ` Matthew Wilcox
2019-09-13 15:39 ` André Almeida
2019-09-13 16:23 ` Jens Axboe
2019-09-13 16:27 ` Chaitanya Kulkarni
2019-09-13 16:48 ` Jens Axboe [this message]
2019-09-11 22:05 ` [PATCH 1/3] docs: block: null_blk: enhance document style Jens Axboe
2019-09-11 22:26 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb344ee1-b7f1-9029-b9c1-177193371b35@kernel.dk \
--to=axboe@kernel.dk \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=andrealmeid@collabora.com \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=m@bjorling.me \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).