From: Johannes Thumshirn <jthumshirn@suse.de>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
linux-nvme@lists.infradead.org
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/4] nvme multipath: expose slaves/holders
Date: Thu, 13 Dec 2018 10:33:13 +0100 [thread overview]
Message-ID: <bd4405c7-560c-f138-78f0-023807f96367@suse.de> (raw)
In-Reply-To: <20181206164812.30925-1-cascardo@canonical.com>
On 06/12/2018 17:48, Thadeu Lima de Souza Cascardo wrote:
> Exposing slaves/holders is necessary in order to find out the real PCI device
> and its driver for the root filesystem when generating an initramfs with
> initramfs-tools. That fails right now for nvme multipath devices, which this
> patchset fixes.
>
> However, because the slave devices are hidden, lsblk fails without some extra
> patches, as it can't find the device numbers for the slave devices, and exits.
Sorry for chiming in so late, can someone give me an explanation what
actually is broken?
I know this is technically a user visible regression, but isn't lsblk
(and others) already fixed? I believe it's [1] in util-linux.
And to find out the PCI device, why do you need slaves/holders here?
Have a look at blktest's _get_pci_dev_from_blkdev() function [2].
[1] d51f05bfecb2 ("lsblk: try device/dev to read devno")
[2] https://github.com/osandov/blktests/blob/master/common/rc#L185
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-12-13 9:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 16:48 [PATCH 0/4] nvme multipath: expose slaves/holders Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` [PATCH 1/4] block: move holder tracking from struct block_device to hd_struct Thadeu Lima de Souza Cascardo
2018-12-13 9:14 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 2/4] nvme: create slaves/holder entries for multipath devices Thadeu Lima de Souza Cascardo
2018-12-13 9:15 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 3/4] nvme: Should not warn when a disk path is opened Thadeu Lima de Souza Cascardo
2018-12-13 9:16 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 4/4] block: expose devt for GENHD_FL_HIDDEN disks Thadeu Lima de Souza Cascardo
2018-12-06 20:22 ` Christoph Hellwig
2018-12-12 8:32 ` Christoph Hellwig
2018-12-12 12:39 ` Thadeu Lima de Souza Cascardo
2018-12-13 9:18 ` Hannes Reinecke
2018-12-13 11:41 ` Thadeu Lima de Souza Cascardo
2018-12-13 12:19 ` Hannes Reinecke
2018-12-13 16:08 ` Thadeu Lima de Souza Cascardo
2018-12-13 14:32 ` Christoph Hellwig
2018-12-13 15:25 ` Thadeu Lima de Souza Cascardo
2018-12-13 20:20 ` Christoph Hellwig
2018-12-13 21:00 ` Thadeu Lima de Souza Cascardo
2018-12-14 7:47 ` Hannes Reinecke
2018-12-14 8:56 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:06 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:54 ` Hannes Reinecke
2018-12-14 10:18 ` Hannes Reinecke
2018-12-14 11:09 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:44 ` Hannes Reinecke
2018-12-13 9:33 ` Johannes Thumshirn [this message]
2018-12-13 11:35 ` [PATCH 0/4] nvme multipath: expose slaves/holders Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4405c7-560c-f138-78f0-023807f96367@suse.de \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=cascardo@canonical.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).