linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+118992efda475c16dfb0@syzkaller.appspotmail.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [syzbot] possible deadlock in loop_add
Date: Mon, 12 Jul 2021 16:29:16 +0800	[thread overview]
Message-ID: <c3d4ebd5-5679-cd81-d1de-4f5f2cbe13db@gmail.com> (raw)
In-Reply-To: <20210712052740.GA8599@lst.de>

On 12/7/21 1:27 pm, Christoph Hellwig wrote:
> On Sat, Jul 10, 2021 at 09:16:38PM +0800, Hillf Danton wrote:
>> To break the lock chain, un/register blkdev without mtd_table_mutex held.
> 
> Yes, Desmond Cheong Zhi Xi sent pretty much the same patch on June 18th
> (mtd: break circular locks in register_mtd_blktrans), but it did not get
> picked up.
> 

I believe Miquèl was waiting for -rc1 to apply it.

But taking a closer look, although the fix for the register path is the 
same, Hillf Danton's proposed patch additionally avoids inverting the 
lock hierarchy on the unregister path. So I believe this new patch 
should be more robust.

Best wishes,
Desmond

  reply	other threads:[~2021-07-12  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 11:01 [syzbot] possible deadlock in loop_add syzbot
     [not found] ` <20210710131638.605-1-hdanton@sina.com>
2021-07-12  5:27   ` Christoph Hellwig
2021-07-12  8:29     ` Desmond Cheong Zhi Xi [this message]
2021-07-15 23:00       ` Miquel Raynal
2021-07-17  9:41         ` Desmond Cheong Zhi Xi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3d4ebd5-5679-cd81-d1de-4f5f2cbe13db@gmail.com \
    --to=desmondcheongzx@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=hdanton@sina.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=syzbot+118992efda475c16dfb0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).