From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E1BDC433ED for ; Mon, 10 May 2021 01:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AE96613ED for ; Mon, 10 May 2021 01:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbhEJBaU (ORCPT ); Sun, 9 May 2021 21:30:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2420 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbhEJBaT (ORCPT ); Sun, 9 May 2021 21:30:19 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Fdk0p4TqgzCqt2; Mon, 10 May 2021 09:26:34 +0800 (CST) Received: from [10.174.178.134] (10.174.178.134) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 09:29:08 +0800 Subject: Re: [RFC PATCH 0/3] block_dump: remove block dump To: Jens Axboe , , , , CC: , , , , , References: <20210313030146.2882027-1-yi.zhang@huawei.com> <15f9c6ce-f22a-59cd-8ce7-eb908f663826@kernel.dk> From: Zhang Yi Message-ID: Date: Mon, 10 May 2021 09:29:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <15f9c6ce-f22a-59cd-8ce7-eb908f663826@kernel.dk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.134] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2021/3/13 11:37, Jens Axboe wrote: > On 3/12/21 8:01 PM, zhangyi (F) wrote: >> Hi, >> >> block_dump is an old debugging interface and can be replaced by >> tracepoints, and we also found a deadlock issue relate to it[1]. As Jan >> suggested, this patch set delete the whole block_dump feature, we can >> use tracepoints to get the similar information. If someone still using >> this feature cannot switch to use tracepoints or any other suggestions, >> please let us know. > > Totally agree, that's long overdue. The feature is no longer useful > and has been deprecated by much better methods. Unless anyone objects, > I'll queue this up for 5.13. > Hi, Jens. Could you please send these patches upstream ? Thanks, Yi.