From: Jens Axboe <axboe@kernel.dk>
To: Greg KH <gregkh@linuxfoundation.org>, Ming Lei <ming.lei@redhat.com>
Cc: "Ray,
Mark C (Global Solutions Engineering (GSE))" <mark.ray@hpe.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: avoid sysfs buffer overflow by too many CPU cores
Date: Fri, 16 Aug 2019 08:21:42 -0600 [thread overview]
Message-ID: <c5b1b6f3-d461-9379-7e5c-6c6bee6a7bd5@kernel.dk> (raw)
In-Reply-To: <20190816071234.GE1368@kroah.com>
On 8/16/19 1:12 AM, Greg KH wrote:
> On Fri, Aug 16, 2019 at 10:49:35AM +0800, Ming Lei wrote:
>> On Thu, Aug 15, 2019 at 11:10:35PM +0000, Ray, Mark C (Global Solutions Engineering (GSE)) wrote:
>>> Hi Ming,
>>>
>>> In the customer case, the cpu_list file was not needed. It was just part of a SAP Hana script to collect all the block device data (similar to sosreport). So they were just dumping everything, and it picks up the mq-related files.
>>>
>>> I know with IRQs, we have bitmaps/mask, and can represent the list such as "0-27", without listing every CPU. I'm sure there's lots of options to address this, and getting rid of the cpu_list is one of them.
>>
>> Indeed, same with several attributes under /sys/devices/system/cpu/,
>> actually we can use cpumap_print_to_pagebuf() to print the CPUs.
>
> And that is changing the format of the file, which means it is obvious
> no one is using it, so just please delete the thing.
IFF that patch was valid, then yes, it follows that you could delete it.
But that's not a given.
--
Jens Axboe
next prev parent reply other threads:[~2019-08-16 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:15 [PATCH] blk-mq: avoid sysfs buffer overflow by too many CPU cores Ming Lei
2019-08-15 12:24 ` Greg KH
2019-08-15 12:29 ` Ming Lei
2019-08-15 12:35 ` Greg KH
2019-08-15 12:43 ` Ming Lei
2019-08-15 13:21 ` Greg KH
2019-08-15 23:10 ` Ray, Mark C (Global Solutions Engineering (GSE))
2019-08-16 2:49 ` Ming Lei
2019-08-16 7:12 ` Greg KH
2019-08-16 14:21 ` Jens Axboe [this message]
2019-11-02 8:02 Ming Lei
2019-11-02 14:03 ` Jens Axboe
2019-11-03 0:25 ` Chaitanya Kulkarni
2019-11-03 15:02 ` Jens Axboe
2019-11-03 20:26 ` Chaitanya Kulkarni
2019-11-03 23:57 ` Ming Lei
2019-11-04 1:56 ` Jens Axboe
2019-11-04 6:57 ` Hannes Reinecke
2019-11-04 14:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b1b6f3-d461-9379-7e5c-6c6bee6a7bd5@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=mark.ray@hpe.com \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).