From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v3] fs: ratelimit __find_get_block_slow() failure message.
Date: Wed, 6 Feb 2019 12:59:10 -0700 [thread overview]
Message-ID: <c64d6020-4779-6938-5d9f-ca67b0644ce5@kernel.dk> (raw)
In-Reply-To: <1548078577-10353-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On 1/21/19 6:49 AM, Tetsuo Handa wrote:
> When something let __find_get_block_slow() hit all_mapped path, it calls
> printk() for 100+ times per a second. But there is no need to print same
> message with such high frequency; it is just asking for stall warning, or
> at least bloating log files.
>
> [ 399.866302][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
> [ 399.873324][T15342] b_state=0x00000029, b_size=512
> [ 399.878403][T15342] device loop0 blocksize: 4096
> [ 399.883296][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
> [ 399.890400][T15342] b_state=0x00000029, b_size=512
> [ 399.895595][T15342] device loop0 blocksize: 4096
> [ 399.900556][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
> [ 399.907471][T15342] b_state=0x00000029, b_size=512
> [ 399.912506][T15342] device loop0 blocksize: 4096
>
> This patch reduces frequency to up to once per a second, in addition to
> concatenating three lines into one.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-02-06 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 13:49 [PATCH v3] fs: ratelimit __find_get_block_slow() failure message Tetsuo Handa
2019-02-06 14:37 ` Tetsuo Handa
2019-02-06 19:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c64d6020-4779-6938-5d9f-ca67b0644ce5@kernel.dk \
--to=axboe@kernel.dk \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).