From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <pdurrant@amazon.com>
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefano Stabellini <sstabellini@kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 1/2] xen/xenbus: reference count registered modules
Date: Tue, 3 Dec 2019 10:47:55 +0100 [thread overview]
Message-ID: <c784e57a-46ea-a839-8c0c-5a299aa5a64f@suse.com> (raw)
In-Reply-To: <20191202114117.1264-2-pdurrant@amazon.com>
On 02.12.2019 12:41, Paul Durrant wrote:
> To prevent a PV driver module being removed whilst attached to its other
> end, and hence xenbus calling into potentially invalid text, take a
> reference on the module before calling the probe() method (dropping it if
> unsuccessful) and drop the reference after returning from the remove()
> method.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
with ...
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -232,9 +232,16 @@ int xenbus_dev_probe(struct device *_dev)
> return err;
> }
>
> + if (!try_module_get(drv->driver.owner)) {
> + dev_warn(&dev->dev, "failed to acquire module reference on '%s'.\n",
> + drv->driver.name);
... perhaps the full stop dropped here and ...
> + err = -ESRCH;
> + goto fail;
> + }
... (definitely) indentation here changed to use a tab.
Jan
next prev parent reply other threads:[~2019-12-03 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 11:41 [PATCH v3 0/2] allow xen-blkback to be cleanly unloaded Paul Durrant
2019-12-02 11:41 ` [PATCH v3 1/2] xen/xenbus: reference count registered modules Paul Durrant
2019-12-03 9:47 ` Jan Beulich [this message]
2019-12-04 10:36 ` Jürgen Groß
2019-12-02 11:41 ` [PATCH v3 2/2] xen-blkback: allow module to be cleanly unloaded Paul Durrant
2019-12-04 10:36 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c784e57a-46ea-a839-8c0c-5a299aa5a64f@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).