From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-block@vger.kernel.org
Cc: Bob Liu <bob.liu@oracle.com>
Subject: [PATCH 1/1] io_uring: Remove extra io_commit_sqring()
Date: Wed, 6 Nov 2019 21:12:08 +0300 [thread overview]
Message-ID: <ca020164c33381c602d3188d95e0d650a5c625ac.1573058949.git.asml.silence@gmail.com> (raw)
io_submit_sqes() calls io_commit_sqring() at the end, so there is no
need for sq_thread to repeat it.
Fixes: 09c0eb1f1b93b9cf ("io_uring: Merge io_submit_sqes and
io_ring_submit").
Reported-by: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index ba77475c1cec..6524898831e0 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2868,9 +2868,6 @@ static int io_sq_thread(void *data)
to_submit = min(to_submit, ctx->sq_entries);
inflight += io_submit_sqes(ctx, to_submit, NULL, -1, &cur_mm,
true);
-
- /* Commit SQ ring head once we've consumed all SQEs */
- io_commit_sqring(ctx);
}
set_fs(old_fs);
--
2.23.0
next reply other threads:[~2019-11-06 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:12 Pavel Begunkov [this message]
2019-11-06 18:17 ` [PATCH 1/1] io_uring: Remove extra io_commit_sqring() Pavel Begunkov
2019-11-06 18:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca020164c33381c602d3188d95e0d650a5c625ac.1573058949.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).