linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: axboe@kernel.dk, Christoph Hellwig <hch@lst.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] bcache: use disk_{start,end}_io_acct() to count I/O for bcache device
Date: Tue, 28 Jul 2020 23:23:09 +0800	[thread overview]
Message-ID: <cdf2090a-c2ea-8fab-ca47-f27305be77b6@suse.de> (raw)
In-Reply-To: <20200728135920.4618-1-colyli@suse.de>

On 2020/7/28 21:59, colyli@suse.de wrote:
> From: Coly Li <colyli@suse.de>
> 
> This patch is a fix to patch "bcache: fix bio_{start,end}_io_acct with
> proper device". The previous patch uses a hack to temporarily set
> bi_disk to bcache device, which is mistaken too.
> 
> As Christoph suggests, this patch uses disk_{start,end}_io_acct() to
> count I/O for bcache device in the correct way.
> 
> Fixes: 85750aeb748f ("bcache: use bio_{start,end}_io_acct")
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: stable@vger.kernel.org


Hi Jens and Christoph,

This patch is tested, the I/O counter behavior is displayed by iostat in
expected way.

Please consider to take it for Linux v5.9.

Thanks in advance.

Coly Li

  reply	other threads:[~2020-07-28 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 13:59 [PATCH] bcache: use disk_{start,end}_io_acct() to count I/O for bcache device colyli
2020-07-28 15:23 ` Coly Li [this message]
2020-07-28 15:23 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdf2090a-c2ea-8fab-ca47-f27305be77b6@suse.de \
    --to=colyli@suse.de \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).