From: Pavel Begunkov <asml.silence@gmail.com>
To: Dennis Zhou <dennis@kernel.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Lameter <cl@linux.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU
Date: Fri, 22 Oct 2021 10:22:30 +0100 [thread overview]
Message-ID: <cdf7c768-47ad-78c4-a22a-f0f1a435b6f6@gmail.com> (raw)
In-Reply-To: <YXFytAdeF5RPRERf@fedora>
On 10/21/21 15:01, Dennis Zhou wrote:
> Hello,
>
> On Thu, Oct 21, 2021 at 02:30:51PM +0100, Pavel Begunkov wrote:
>> Add percpu_ref_tryget_live_rcu(), which is a version of
>> percpu_ref_tryget_live() but the user is responsible for enclosing it in
>> a RCU read lock section.
>>
>> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
>> ---
>> include/linux/percpu-refcount.h | 33 +++++++++++++++++++++++----------
>> 1 file changed, 23 insertions(+), 10 deletions(-)
>>
[...]
>> +
>> /**
>> * percpu_ref_tryget_live - try to increment a live percpu refcount
>> * @ref: percpu_ref to try-get
>
> Nit: it's dumb convention at this point, but do you mind copying this
> guy up. I like consistency.
Looks Jens already took it. If you still want it moved, do you mind
it in a separate patch?
And I'm not sure I follow where you want it to be, currently it's
right before percpu_ref_tryget_live, which uses it.
--
Pavel Begunkov
next prev parent reply other threads:[~2021-10-22 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 13:30 [PATCH v2 0/2] optimise blk_try_enter_queue() Pavel Begunkov
2021-10-21 13:30 ` [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU Pavel Begunkov
2021-10-21 14:01 ` Dennis Zhou
2021-10-22 9:22 ` Pavel Begunkov [this message]
2021-10-22 19:22 ` Dennis Zhou
2021-10-21 13:30 ` [PATCH v2 2/2] block: kill extra rcu lock/unlock in queue enter Pavel Begunkov
2021-10-21 14:37 ` [PATCH v2 0/2] optimise blk_try_enter_queue() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdf7c768-47ad-78c4-a22a-f0f1a435b6f6@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).