From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-block@vger.kernel.org, linux-arch@vger.kernel.org,
hch@lst.de, avi@scylladb.com
Subject: Re: [PATCH 15/15] io_uring: add io_uring_event cache hit information
Date: Thu, 10 Jan 2019 16:47:28 -0700 [thread overview]
Message-ID: <cf92044f-1672-1354-b1c4-b86de52f55b9@kernel.dk> (raw)
In-Reply-To: <x4936q0ds3y.fsf@segfault.boston.devel.redhat.com>
On 1/10/19 4:12 PM, Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>
>> Add hint on whether a read was served out of the page cache, or if it
>> hit media. This is useful for buffered async IO, O_DIRECT reads would
>> never have this set (for obvious reasons).
>>
>> If the read hit page cache, cqe->flags will have IOCQE_FLAG_CACHEHIT
>> set.
>
> We may want to hold off on this one until the whole mincore/RWF_NOWAIT
> debate is sorted. [1]
Definitely, it's why it's separate and at the end of the series. But
in reality, this doesn't leak anything that timing doesn't already
tell you. So it's kind of a moot point.
--
Jens Axboe
next prev parent reply other threads:[~2019-01-10 23:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 2:43 [PATCHSET v2] io_uring IO interface Jens Axboe
2019-01-10 2:43 ` [PATCH 01/15] fs: add an iopoll method to struct file_operations Jens Axboe
2019-01-10 2:43 ` [PATCH 02/15] block: wire up block device iopoll method Jens Axboe
2019-01-10 2:43 ` [PATCH 03/15] block: add bio_set_polled() helper Jens Axboe
2019-01-10 2:43 ` [PATCH 04/15] iomap: wire up the iopoll method Jens Axboe
2019-01-10 2:43 ` [PATCH 05/15] Add io_uring IO interface Jens Axboe
2019-01-11 18:19 ` Martin K. Petersen
2019-01-11 18:34 ` Jens Axboe
2019-01-13 16:22 ` Jens Axboe
2019-01-15 17:31 ` Martin K. Petersen
2019-01-10 2:43 ` [PATCH 06/15] io_uring: support for IO polling Jens Axboe
2019-01-10 2:43 ` [PATCH 07/15] io_uring: add submission side request cache Jens Axboe
2019-01-10 2:43 ` [PATCH 08/15] fs: add fget_many() and fput_many() Jens Axboe
2019-01-10 2:43 ` [PATCH 09/15] io_uring: use fget/fput_many() for file references Jens Axboe
2019-01-10 2:43 ` [PATCH 10/15] io_uring: batch io_kiocb allocation Jens Axboe
2019-01-10 2:44 ` [PATCH 11/15] block: implement bio helper to add iter bvec pages to bio Jens Axboe
2019-01-10 2:44 ` [PATCH 12/15] io_uring: add support for pre-mapped user IO buffers Jens Axboe
2019-01-10 2:44 ` [PATCH 13/15] io_uring: support kernel side submission Jens Axboe
2019-01-10 2:44 ` [PATCH 14/15] io_uring: add submission polling Jens Axboe
2019-01-10 2:44 ` [PATCH 15/15] io_uring: add io_uring_event cache hit information Jens Axboe
2019-01-10 23:12 ` Jeff Moyer
2019-01-10 23:47 ` Jens Axboe [this message]
2019-01-11 9:46 ` [PATCHSET v2] io_uring IO interface Roman Penyaev
2019-01-11 16:11 ` Ilya Dryomov
2019-01-11 16:21 ` Christoph Hellwig
2019-01-11 16:39 ` Roman Penyaev
2019-01-11 18:05 ` Jens Axboe
2019-01-16 17:49 [PATCHSET v5] " Jens Axboe
2019-01-16 17:50 ` [PATCH 15/15] io_uring: add io_uring_event cache hit information Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf92044f-1672-1354-b1c4-b86de52f55b9@kernel.dk \
--to=axboe@kernel.dk \
--cc=avi@scylladb.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).