From: "Pavel Begunkov (Silence)" <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
josef@toxicpanda.com
Cc: Pavel Begunkov <asml.silence@gmail.com>
Subject: [RESEND][PATCH v2 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Date: Fri, 6 Sep 2019 17:42:02 +0300 [thread overview]
Message-ID: <cover.1567780718.git.asml.silence@gmail.com> (raw)
From: Pavel Begunkov <asml.silence@gmail.com>
There are implicit assumptions about struct blk_rq_stats, which make
it's very easy to misuse. The first patch fixes a bug caused by that.
The second employs type-system to prevent recurrences.
v2: rebase + reformulate commit messages (no code changes)
Acked-by: Josef Bacik <josef@toxicpanda.com>
Pavel Begunkov (2):
blk-iolatency: Fix zero mean in previous stats
blk-stats: Introduce explicit stat staging buffers
block/blk-iolatency.c | 60 ++++++++++++++++++++++++++++++---------
block/blk-stat.c | 48 +++++++++++++++++++++++--------
block/blk-stat.h | 9 ++++--
include/linux/blk_types.h | 6 ++++
4 files changed, 94 insertions(+), 29 deletions(-)
--
2.22.0
next reply other threads:[~2019-09-06 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:42 Pavel Begunkov (Silence) [this message]
2019-09-06 14:42 ` [PATCH v2 1/2] blk-iolatency: Fix zero mean in previous stats Pavel Begunkov (Silence)
2019-09-06 14:42 ` [PATCH v2 2/2] blk-stats: Introduce explicit stat staging buffers Pavel Begunkov (Silence)
2019-09-06 15:00 ` [RESEND][PATCH v2 0/2] Fix misuse of blk_rq_stats in blk-iolatency Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1567780718.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).