* [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue
@ 2020-05-17 11:49 Baolin Wang
2020-05-18 3:54 ` Ming Lei
2020-05-19 15:42 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Baolin Wang @ 2020-05-17 11:49 UTC (permalink / raw)
To: axboe; +Cc: baolin.wang7, linux-block, linux-kernel
The flush_queue_delayed was introdued to hold queue if flush is
running for non-queueable flush drive by commit 3ac0cc450870
("hold queue if flush is running for non-queueable flush drive"),
but the non mq parts of the flush code had been removed by
commit 7e992f847a08 ("block: remove non mq parts from the flush code"),
as well as removing the usage of the flush_queue_delayed flag.
Thus remove the unused flush_queue_delayed flag.
Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
---
block/blk-flush.c | 1 -
block/blk.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/block/blk-flush.c b/block/blk-flush.c
index c7f396e3d5e2..b733f7ac75c7 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -258,7 +258,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error)
blk_flush_complete_seq(rq, fq, seq, error);
}
- fq->flush_queue_delayed = 0;
spin_unlock_irqrestore(&fq->mq_flush_lock, flags);
}
diff --git a/block/blk.h b/block/blk.h
index fc00537026a0..6cab33a11f90 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -19,7 +19,6 @@ extern struct dentry *blk_debugfs_root;
#endif
struct blk_flush_queue {
- unsigned int flush_queue_delayed:1;
unsigned int flush_pending_idx:1;
unsigned int flush_running_idx:1;
blk_status_t rq_status;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue
2020-05-17 11:49 [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue Baolin Wang
@ 2020-05-18 3:54 ` Ming Lei
2020-05-19 15:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2020-05-18 3:54 UTC (permalink / raw)
To: Baolin Wang; +Cc: Jens Axboe, linux-block, Linux Kernel Mailing List
On Sun, May 17, 2020 at 7:51 PM Baolin Wang <baolin.wang7@gmail.com> wrote:
>
> The flush_queue_delayed was introdued to hold queue if flush is
> running for non-queueable flush drive by commit 3ac0cc450870
> ("hold queue if flush is running for non-queueable flush drive"),
> but the non mq parts of the flush code had been removed by
> commit 7e992f847a08 ("block: remove non mq parts from the flush code"),
> as well as removing the usage of the flush_queue_delayed flag.
> Thus remove the unused flush_queue_delayed flag.
>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> block/blk-flush.c | 1 -
> block/blk.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/block/blk-flush.c b/block/blk-flush.c
> index c7f396e3d5e2..b733f7ac75c7 100644
> --- a/block/blk-flush.c
> +++ b/block/blk-flush.c
> @@ -258,7 +258,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error)
> blk_flush_complete_seq(rq, fq, seq, error);
> }
>
> - fq->flush_queue_delayed = 0;
> spin_unlock_irqrestore(&fq->mq_flush_lock, flags);
> }
>
> diff --git a/block/blk.h b/block/blk.h
> index fc00537026a0..6cab33a11f90 100644
> --- a/block/blk.h
> +++ b/block/blk.h
> @@ -19,7 +19,6 @@ extern struct dentry *blk_debugfs_root;
> #endif
>
> struct blk_flush_queue {
> - unsigned int flush_queue_delayed:1;
> unsigned int flush_pending_idx:1;
> unsigned int flush_running_idx:1;
> blk_status_t rq_status;
> --
> 2.17.1
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming Lei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue
2020-05-17 11:49 [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue Baolin Wang
2020-05-18 3:54 ` Ming Lei
@ 2020-05-19 15:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-05-19 15:42 UTC (permalink / raw)
To: Baolin Wang; +Cc: linux-block, linux-kernel
On 5/17/20 5:49 AM, Baolin Wang wrote:
> The flush_queue_delayed was introdued to hold queue if flush is
> running for non-queueable flush drive by commit 3ac0cc450870
> ("hold queue if flush is running for non-queueable flush drive"),
> but the non mq parts of the flush code had been removed by
> commit 7e992f847a08 ("block: remove non mq parts from the flush code"),
> as well as removing the usage of the flush_queue_delayed flag.
> Thus remove the unused flush_queue_delayed flag.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-19 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-17 11:49 [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue Baolin Wang
2020-05-18 3:54 ` Ming Lei
2020-05-19 15:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).