From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4DAC43603 for ; Wed, 4 Dec 2019 10:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A6342068E for ; Wed, 4 Dec 2019 10:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbfLDKgf (ORCPT ); Wed, 4 Dec 2019 05:36:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:39216 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727268AbfLDKge (ORCPT ); Wed, 4 Dec 2019 05:36:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 60BBDB164; Wed, 4 Dec 2019 10:36:32 +0000 (UTC) Subject: Re: [PATCH v3 1/2] xen/xenbus: reference count registered modules To: Paul Durrant , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jan Beulich , Boris Ostrovsky , Stefano Stabellini References: <20191202114117.1264-1-pdurrant@amazon.com> <20191202114117.1264-2-pdurrant@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Wed, 4 Dec 2019 11:36:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191202114117.1264-2-pdurrant@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 02.12.19 12:41, Paul Durrant wrote: > To prevent a PV driver module being removed whilst attached to its other > end, and hence xenbus calling into potentially invalid text, take a > reference on the module before calling the probe() method (dropping it if > unsuccessful) and drop the reference after returning from the remove() > method. > > Suggested-by: Jan Beulich > Signed-off-by: Paul Durrant Pushed to xen/tip.git for-linus-5.5b Juergen