From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, linux-raid@vger.kernel.org,
Song Liu <song@kernel.org>,
linux-nvme@lists.infradead.org, Tejun Heo <tj@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH 1/2] percpu_ref: add percpu_ref_tryget_many_live
Date: Thu, 15 Apr 2021 12:50:43 -0700 [thread overview]
Message-ID: <dcdc3233-b4a6-24b2-85dd-78ed9e70fef1@acm.org> (raw)
In-Reply-To: <20210415103310.1513841-2-ming.lei@redhat.com>
On 4/15/21 3:33 AM, Ming Lei wrote:
> /**
> - * percpu_ref_tryget_live - try to increment a live percpu refcount
> + * percpu_ref_tryget_many_live - try to increment a live percpu refcount
> * @ref: percpu_ref to try-get
> + * @nr: number of references to get
You may want to change "increment" into "increase" to make it more clear
that this function may increase the percpu refcount by more than one.
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2021-04-15 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:33 [RFC PATCH 0/2] block: support to freeze bio based queue Ming Lei
2021-04-15 10:33 ` [RFC PATCH 1/2] percpu_ref: add percpu_ref_tryget_many_live Ming Lei
2021-04-15 19:50 ` Bart Van Assche [this message]
2021-04-15 10:33 ` [RFC PATCH 2/2] block: support to freeze bio based request queue Ming Lei
2021-04-15 13:56 ` Ming Lei
2021-04-15 20:16 ` [dm-devel] " Bart Van Assche
2021-04-16 1:28 ` Ming Lei
2021-04-19 12:05 ` JeffleXu
2021-04-19 13:50 ` Ming Lei
2021-04-20 7:21 ` JeffleXu
2021-04-20 7:58 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcdc3233-b4a6-24b2-85dd-78ed9e70fef1@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).