linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, linux-block@vger.kernel.org
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [RFC] bio: fix page leak bio_add_hw_page failure
Date: Tue, 24 Aug 2021 08:05:19 -0600	[thread overview]
Message-ID: <e009dc29-6b05-184d-513c-ffcb175ab34c@kernel.dk> (raw)
In-Reply-To: <1edfa6a2ffd66d55e6345a477df5387d2c1415d0.1626653825.git.asml.silence@gmail.com>

On 7/19/21 4:53 AM, Pavel Begunkov wrote:
> __bio_iov_append_get_pages() doesn't put not appended pages on
> bio_add_hw_page() failure, so potentially leaking them, fix it. Also, do
> the same for __bio_iov_iter_get_pages(), even though it looks like it
> can't be triggered by userspace in this case.

Applied for 5.15, thanks.

-- 
Jens Axboe


      parent reply	other threads:[~2021-08-24 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 10:53 [RFC] bio: fix page leak bio_add_hw_page failure Pavel Begunkov
2021-07-19 15:34 ` Ming Lei
2021-07-19 17:06   ` Pavel Begunkov
2021-07-20  2:11     ` Ming Lei
2021-07-21 14:44       ` Pavel Begunkov
2021-08-08 12:57 ` Pavel Begunkov
2021-08-24 14:05 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e009dc29-6b05-184d-513c-ffcb175ab34c@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).