From: Coly Li <colyli@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Jianpeng Ma <jianpeng.ma@intel.com>,
Qiaowei Ren <qiaowei.ren@intel.com>
Subject: Re: [PATCH 07/20] bcache: add initial data structures for nvm pages
Date: Thu, 11 Feb 2021 11:58:23 +0800 [thread overview]
Message-ID: <e2b05bd8-8129-73f1-2f17-00eb95ce5184@suse.de> (raw)
In-Reply-To: <76adf7d2-821b-c7a5-426e-4d3963d36455@kernel.dk>
On 2/10/21 11:09 PM, Jens Axboe wrote:
> On 2/9/21 10:07 PM, Coly Li wrote:
>> +struct bch_nvm_pgalloc_recs {
>> +union {
>> + struct {
>> + struct bch_nvm_pages_owner_head *owner;
>> + struct bch_nvm_pgalloc_recs *next;
>> + __u8 magic[16];
>> + __u8 owner_uuid[16];
>> + __u32 size;
>> + __u32 used;
>> + __u64 _pad[4];
>> + struct bch_pgalloc_rec recs[];
>> + };
>> + __u8 pad[8192];
>> +};
>> +};
>
Hi Jens,
> This doesn't look right in a user header, any user API should be 32-bit
> and 64-bit agnostic.
The above data structure is stored in NVDIMM as allocator's meta data.
It is designed to be directly accessed (in future update) as in-memory
object, but stored on non-volatiled memory like on-disk data structure.
To me, it is fine to use unsigned int/long/long long to define the
members, because nvdimm driver only works on 64bit platform. It is just
unclear to me which form/style I should use to define such data
structure. On one side they are stores as non-volatiled media, on other
side they are accessed directly as in-memory object...
>
>> +struct bch_nvm_pages_owner_head {
>> + __u8 uuid[16];
>> + char label[BCH_NVM_PAGES_LABEL_SIZE];
>> + /* Per-namespace own lists */
>> + struct bch_nvm_pgalloc_recs *recs[BCH_NVM_PAGES_NAMESPACES_MAX];
>> +};
>
> Same here.
For the above pointer, it is the same reason. In later version, such
object on NVDIMM will be referenced directly by an in-memory pointer
like we normally do for an in-memory object.
Therefore I do treat the data structure as in-memory object after the
DAX mapping accomplished. If not define it as an in-memory pointer, I
have to cast it into (void *) every time when I use it.
>
>> +/* heads[0] is always for nvm_pages internal usage */
>> +struct bch_owner_list_head {
>> +union {
>> + struct {
>> + __u32 size;
>> + __u32 used;
>> + __u64 _pad[4];
>> + struct bch_nvm_pages_owner_head heads[];
>> + };
>> + __u8 pad[8192];
>> +};
>> +};
>
> And here.
>
>> +#define BCH_MAX_OWNER_LIST \
>> + ((sizeof(struct bch_owner_list_head) - \
>> + offsetof(struct bch_owner_list_head, heads)) / \
>> + sizeof(struct bch_nvm_pages_owner_head))
>> +
>> +/* The on-media bit order is local CPU order */
>> +struct bch_nvm_pages_sb {
>> + __u64 csum;
>> + __u64 ns_start;
>> + __u64 sb_offset;
>> + __u64 version;
>> + __u8 magic[16];
>> + __u8 uuid[16];
>> + __u32 page_size;
>> + __u32 total_namespaces_nr;
>> + __u32 this_namespace_nr;
>> + union {
>> + __u8 set_uuid[16];
>> + __u64 set_magic;
>> + };
>
> This doesn't look like it packs right either.
This is my mimicry from bcache code, which uses the least significant 8
bytes from the randomly generated UUID as a magic number. It is solid
and not changed during the whole life cycle for the nvm pages set.
>
>> +
>> + __u64 flags;
>> + __u64 seq;
>> +
>> + __u64 feature_compat;
>> + __u64 feature_incompat;
>> + __u64 feature_ro_compat;
>> +
>> + /* For allocable nvm pages from buddy systems */
>> + __u64 pages_offset;
>> + __u64 pages_total;
>> +
>> + __u64 pad[8];
>> +
>> + /* Only on the first name space */
>> + struct bch_owner_list_head *owner_list_head;
>
> And here's another pointer...
>
Same reason for I use it as an in-memory pointer.
The above definition is just using all the structures as in-memory
object, the difference is just they are non-volatiled after reboot.
Thanks.
Coly Li
next prev parent reply other threads:[~2021-02-11 3:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 5:07 [PATCH 00/20] bcache patches for Linux v5.12 Coly Li
2021-02-10 5:07 ` [PATCH 01/20] bcache: consider the fragmentation when update the writeback rate Coly Li
2021-02-10 5:07 ` [PATCH 02/20] bcache: Fix register_device_aync typo Coly Li
2021-02-10 5:07 ` [PATCH 03/20] Revert "bcache: Kill btree_io_wq" Coly Li
2021-02-10 5:07 ` [PATCH 04/20] bcache: Give btree_io_wq correct semantics again Coly Li
2021-02-10 5:07 ` [PATCH 05/20] bcache: Move journal work to new flush wq Coly Li
2021-02-10 5:07 ` [PATCH 06/20] bcache: Avoid comma separated statements Coly Li
2021-02-10 5:07 ` [PATCH 07/20] bcache: add initial data structures for nvm pages Coly Li
2021-02-10 15:09 ` Jens Axboe
2021-02-11 3:58 ` Coly Li [this message]
2021-02-10 5:07 ` [PATCH 08/20] bcache: initialize the nvm pages allocator Coly Li
2021-02-10 5:07 ` [PATCH 09/20] bcache: initialization of the buddy Coly Li
2021-02-10 5:07 ` [PATCH 10/20] bcache: bch_nvm_alloc_pages() " Coly Li
2021-02-10 5:07 ` [PATCH 11/20] bcache: bch_nvm_free_pages() " Coly Li
2021-02-10 5:07 ` [PATCH 12/20] bcache: get allocated pages from specific owner Coly Li
2021-02-10 5:07 ` [PATCH 13/20] bcache: persist owner info when alloc/free pages Coly Li
2021-02-10 5:07 ` [PATCH 14/20] bcache: use bucket index for SET_GC_MARK() in bch_btree_gc_finish() Coly Li
2021-02-10 5:07 ` [PATCH 15/20] bcache: add BCH_FEATURE_INCOMPAT_NVDIMM_META into incompat feature set Coly Li
2021-02-10 5:07 ` [PATCH 16/20] bcache: initialize bcache journal for NVDIMM meta device Coly Li
2021-02-10 5:07 ` [PATCH 17/20] bcache: support storing bcache journal into " Coly Li
2021-02-18 21:21 ` Nix
2021-02-10 5:07 ` [PATCH 18/20] bcache: read jset from NVDIMM pages for journal replay Coly Li
2021-02-10 5:07 ` [PATCH 19/20] bcache: add sysfs interface register_nvdimm_meta to register NVDIMM meta device Coly Li
2021-02-10 5:07 ` [PATCH 20/20] bcache: only initialize nvm-pages allocator when CONFIG_BCACHE_NVM_PAGES configured Coly Li
2021-02-10 15:11 ` [PATCH 00/20] bcache patches for Linux v5.12 Jens Axboe
2021-02-12 16:09 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b05bd8-8129-73f1-2f17-00eb95ce5184@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=jianpeng.ma@intel.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=qiaowei.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).