From: "Matias Bjørling" <mb@lightnvm.io>
To: menglong8.dong@gmail.com
Cc: linux-block@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhang Yunkai <zhang.yunkai@zte.com.cn>
Subject: Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h
Date: Tue, 13 Apr 2021 12:55:28 +0200 [thread overview]
Message-ID: <e2bd4734-959c-4505-7e1c-ccc04185e4d3@lightnvm.io> (raw)
In-Reply-To: <20210313112241.366786-1-zhang.yunkai@zte.com.cn>
On 13/03/2021 12.22, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
> It is also included in the 33th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
> include/uapi/linux/lightnvm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
> index ead2e72e5c88..2745afd9b8fa 100644
> --- a/include/uapi/linux/lightnvm.h
> +++ b/include/uapi/linux/lightnvm.h
> @@ -22,7 +22,6 @@
>
> #ifdef __KERNEL__
> #include <linux/const.h>
> -#include <linux/ioctl.h>
> #else /* __KERNEL__ */
> #include <stdio.h>
> #include <sys/ioctl.h>
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches
into one.
next prev parent reply other threads:[~2021-04-13 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 11:22 [PATCH] lightnvm: remove duplicate include in lightnvm.h menglong8.dong
2021-04-13 10:55 ` Matias Bjørling [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-13 10:48 menglong8.dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2bd4734-959c-4505-7e1c-ccc04185e4d3@lightnvm.io \
--to=mb@lightnvm.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).