linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"danil.kipnis@cloud.ionos.com" <danil.kipnis@cloud.ionos.com>,
	"jinpu.wang@cloud.ionos.com" <jinpu.wang@cloud.ionos.com>,
	"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH V2 3/4] block: add io_extra_stats node
Date: Tue, 2 Feb 2021 02:29:08 +0100	[thread overview]
Message-ID: <e335365a-4839-a240-2817-c34b9ef51d18@cloud.ionos.com> (raw)
In-Reply-To: <SN4PR0401MB35980F52820FF8D6B0E3D8DD9BB69@SN4PR0401MB3598.namprd04.prod.outlook.com>



On 2/1/21 10:47, Johannes Thumshirn wrote:
> On 01/02/2021 02:30, Guoqing Jiang wrote:
>> If user doesn't care about the size and latency of io, and they could
>> suffer from the additional overhead. So introduce a specific sysfs node
>> to avoid such mistake.
> 
> 
> I would make this patch number 1 in the series and then merge patch 4
> (the check for blk_queue_io_extra_stat()) into the patches adding
> blk_additional_latency() and blk_additional_sector().
> 
> 

Ok, thanks for the suggestion.

Guoqing

  reply	other threads:[~2021-02-02  1:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  1:27 [PATCH V2 0/4] block: add two statistic tables Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 1/4] block: add a statistic table for io latency Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 2/4] block: add a statistic table for io sector Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 3/4] block: add io_extra_stats node Guoqing Jiang
2021-02-01  9:47   ` Johannes Thumshirn
2021-02-02  1:29     ` Guoqing Jiang [this message]
2021-02-01  1:27 ` [PATCH V2 4/4] block: call blk_additional_{latency,sector} only when io_extra_stats is true Guoqing Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e335365a-4839-a240-2817-c34b9ef51d18@cloud.ionos.com \
    --to=guoqing.jiang@cloud.ionos.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=danil.kipnis@cloud.ionos.com \
    --cc=hch@infradead.org \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).