From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D18C433F5 for ; Fri, 10 Sep 2021 21:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8023F61074 for ; Fri, 10 Sep 2021 21:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233100AbhIJVm4 (ORCPT ); Fri, 10 Sep 2021 17:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhIJVm4 (ORCPT ); Fri, 10 Sep 2021 17:42:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 990B3C061574; Fri, 10 Sep 2021 14:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=leZ9gAJesxiaYyECvXAC95tfjrMi+xyfNBHPusNmXhc=; b=jOxNEkflIY8q+uoW+nXRu9FQ7U nFWTvXtl1dJ9Pdrc9LEPeJMj6UZYxV45Kbrks3XU1zNWuNHv7P/xx3oeYZ5zY0wPTPNZm8YiNSbKJ /I/GJbGoeqCrx83c/VDLP24V7Wy9FePPlXS4m4OP8fOma/KSJ9QB9Hd5bpc1cPbw2zEDp25wMk66X pWz6S+8VNX+Mv6ePijXJdLrwWLLnj/jzSXs8gP5kG/k/4HSmFmY08LNzNIWtTKAiCGeLYH7077uX8 PdaX1OJM0a/1qAxKBUkSIjZyAsN2m3eOTA3c/rSQyjB4vNt2zLcj9/gjYCNOuIdF/9wS2gSs+DvBq e/wW9kow==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOoHH-00DtxH-El; Fri, 10 Sep 2021 21:41:43 +0000 Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection To: Lukas Prediger , phil@philpotter.co.uk Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, hch@infradead.org References: <20210910211600.5663-1-lumip@lumip.de> From: Randy Dunlap Message-ID: Date: Fri, 10 Sep 2021 14:41:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910211600.5663-1-lumip@lumip.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Lukas, Just a minor nit: On 9/10/21 2:16 PM, Lukas Prediger wrote: > +#define MEDIA_CHANGED_FLAG 0x1 /* Last detected media change was more \ > + * recent than last_media_change set by\ > + * caller. \ > + */ Drop the "continuation" backslashes. They are not needed. thanks. -- ~Randy