From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@infradead.org>,
Baolin Wang <baolin.wang7@gmail.com>
Cc: axboe@kernel.dk, ulf.hansson@linaro.org, adrian.hunter@intel.com,
arnd@arndb.de, linus.walleij@linaro.org,
paolo.valente@linaro.org, ming.lei@redhat.com,
orsonzhai@gmail.com, zhang.lyra@gmail.com,
linux-mmc@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/7] block: Extand commit_rqs() to do batch processing
Date: Fri, 8 May 2020 14:35:35 -0700 [thread overview]
Message-ID: <e4d47000-f89c-a135-ae58-011f0e9cc39e@grimberg.me> (raw)
In-Reply-To: <20200427154645.GA1201@infradead.org>
>> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
>> index f389d7c724bd..6a20f8e8eb85 100644
>> --- a/include/linux/blk-mq.h
>> +++ b/include/linux/blk-mq.h
>> @@ -391,6 +391,7 @@ struct blk_mq_ops {
>> enum {
>> BLK_MQ_F_SHOULD_MERGE = 1 << 0,
>> BLK_MQ_F_TAG_SHARED = 1 << 1,
>> + BLK_MQ_F_FORCE_COMMIT_RQS = 1 << 3,
>
> Maybe BLK_MQ_F_ALWAYS_COMMIT might be a better name? Also this
> flag (just like the existing ones..) could really use a comment
> explaining it.
Would it make sense to elevate this flag to a request_queue flag
(QUEUE_FLAG_ALWAYS_COMMIT)?
I'm thinking of a possibility that an I/O scheduler may be used
to activate this functionality rather than having the driver set
it necessarily...
next prev parent reply other threads:[~2020-05-08 21:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 9:38 [RFC PATCH v2 0/7] Add MMC packed request support Baolin Wang
2020-04-26 9:38 ` [RFC PATCH v2 1/7] block: Extand commit_rqs() to do batch processing Baolin Wang
2020-04-27 15:46 ` Christoph Hellwig
2020-04-28 8:02 ` Baolin Wang
2020-05-08 21:35 ` Sagi Grimberg [this message]
2020-05-08 21:46 ` Ming Lei
2020-05-08 22:19 ` Sagi Grimberg
2020-05-08 23:22 ` Ming Lei
2020-05-09 8:57 ` Baolin Wang
2020-05-09 9:43 ` Ming Lei
2020-05-10 7:44 ` Sagi Grimberg
2020-05-11 1:29 ` Ming Lei
2020-05-11 9:23 ` Sagi Grimberg
2020-05-11 11:47 ` Ming Lei
2020-05-12 6:26 ` Sagi Grimberg
2020-05-12 7:55 ` Ming Lei
2020-04-26 9:38 ` [RFC PATCH v2 2/7] mmc: Add MMC packed request support for MMC software queue Baolin Wang
2020-04-26 9:38 ` [RFC PATCH v2 3/7] mmc: host: sdhci: Introduce ADMA3 transfer mode Baolin Wang
2020-04-26 9:38 ` [RFC PATCH v2 4/7] mmc: host: sdhci: Factor out the command configuration Baolin Wang
2020-04-26 9:38 ` [RFC PATCH v2 5/7] mmc: host: sdhci: Remove redundant sg_count member of struct sdhci_host Baolin Wang
2020-04-26 9:38 ` [RFC PATCH v2 6/7] mmc: host: sdhci: Add MMC packed request support Baolin Wang
2020-04-26 9:39 ` [RFC PATCH v2 7/7] mmc: host: sdhci-sprd: " Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d47000-f89c-a135-ae58-011f0e9cc39e@grimberg.me \
--to=sagi@grimberg.me \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=hch@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=orsonzhai@gmail.com \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).