From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A07C35280 for ; Wed, 2 Oct 2019 13:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 784AC21920 for ; Wed, 2 Oct 2019 13:09:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="rivVgCtt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727590AbfJBNJc (ORCPT ); Wed, 2 Oct 2019 09:09:32 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:44386 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfJBNJb (ORCPT ); Wed, 2 Oct 2019 09:09:31 -0400 Received: by mail-io1-f67.google.com with SMTP id w12so28575718iol.11 for ; Wed, 02 Oct 2019 06:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=LGBRuLqUYrX9GGEZI9KKoyUAhJq9ZXxDsRWTIcZfJKs=; b=rivVgCttX729kcL32gPJi94oiGeS/ifekn7WfKH0+689qAHuwZ9GMA8DoZ3c1HyAR/ hLXUYrXvu/gAXPTX4iddYvXTTqa4Clmf9rHuwEC5ng0E4lqdeTmrusQ/3rMg9Hl8tJ66 T/m4Lsd230UKL4EoovEAS51KnE/io9py1nKfWosvvFoE9iykZLeRcp4WbIiPCEXcoAaM BSq09rThM9NHC2ODOBVwG3W/Dl7wBBGv/xnvIoC4NIAcf4Ld3PmW3sXbRdGHT3rKj+CD 3QwI4qifLJc1emxI5N20ihafo6GqeuuARQ7FOLsRk9ryt9v0nRr/G404yZpHtpR9ECkF XYEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LGBRuLqUYrX9GGEZI9KKoyUAhJq9ZXxDsRWTIcZfJKs=; b=G0qz1h2n2/Y16N2N2ojd7l6MyMo7y74OLwV3w3xQ/gr/dNRa1X9WnsV+ysOb5OC5Ns dg1vR0aTvAOykKXD/D2wxJzKg3GhbMrXZ9JPCjnAivCE6fFGVDdWzipbP7fDRNrTSDCP GUDhomi2k2FkEX3jhQXNun5pQhig7BwUndgJ8JFtuaJR5XHYO0GCMvSsz26FfWsQkvbZ s1SeeCFWkaG2f0YED28n79nswwyRLK+UnU8OqiRkBEf4I1jsun9kGhcnNjkjfkQ8nKWo Zzr5c4PcITgOJ9DvucJkEEkaaYRkp+HYwsy8U4jh9Nmra6u5F0KMQ1Oh2Qr2+aaIBKOL CFrg== X-Gm-Message-State: APjAAAXpJyaCzUWELusFNLlbBc3p49Cer3hG/m2BIWrxLcpGvowHsHb0 BgOxN8NBX8plNOWFxxTlOnohuw== X-Google-Smtp-Source: APXvYqxoOv3gPtGv+2gVmJxtYhhJTGAOSpJ5159QObAXDK3v9RjA9LkKGLL73o5+qLKCvndxIogJsA== X-Received: by 2002:a5e:8341:: with SMTP id y1mr2926558iom.284.1570021769994; Wed, 02 Oct 2019 06:09:29 -0700 (PDT) Received: from [192.168.1.50] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id c4sm7265663ilh.32.2019.10.02.06.09.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2019 06:09:29 -0700 (PDT) Subject: Re: [PATCH v2 1/1] blk-mq: Inline request status checkers To: Pavel Begunkov , Bart Van Assche , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org References: <1cd320dad54bd78cb6721f7fe8dd2e197b9fbfa2.1569830796.git.asml.silence@gmail.com> <6da099e2-7e29-3c7b-7682-df86835e9e8c@gmail.com> From: Jens Axboe Message-ID: Date: Wed, 2 Oct 2019 07:09:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <6da099e2-7e29-3c7b-7682-df86835e9e8c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/30/19 2:12 PM, Pavel Begunkov wrote: > On 30/09/2019 22:53, Bart Van Assche wrote: >> On 9/30/19 12:43 PM, Pavel Begunkov (Silence) wrote: >>> @@ -282,7 +282,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) >>> * test and set the bit before assining ->rqs[]. >>> */ >>> rq = tags->rqs[bitnr]; >>> - if (rq && blk_mq_request_started(rq)) >>> + if (rq && blk_mq_rq_state(rq) != MQ_RQ_IDLE) >>> return iter_data->fn(rq, iter_data->data, reserved); >>> >>> return true> >>> @@ -360,7 +360,7 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, >>> { >>> unsigned *count = data; >>> >>> - if (blk_mq_request_completed(rq)) >>> + if (blk_mq_rq_state(rq) == MQ_RQ_COMPLETE) >>> (*count)++; >>> return true; >>> } >> >> Changes like the above significantly reduce readability of the code in >> the block layer core. I don't like this. I think this patch is a step >> backwards instead of a step forwards. > > Yep, looks too bulky. > > Jens, could you consider the first version? Yes, first one is fine, I have applied it. Thanks. -- Jens Axboe