From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA20C6FD1C for ; Wed, 22 Mar 2023 22:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjCVWel (ORCPT ); Wed, 22 Mar 2023 18:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjCVWek (ORCPT ); Wed, 22 Mar 2023 18:34:40 -0400 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE9940FF for ; Wed, 22 Mar 2023 15:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1679524479; x=1711060479; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GRC+ab3cu9sXA63M9BMs8MDzDk/qWTmdP9YEIETyYIY=; b=hDgAHjOdlxRqsmwXLrDY3OGkn3UhpVe6Ta2ZAlOJoVEQ4gyYfXcZlGYn AKQOBfRO1r+kJI6wTCHgtRP0pydiSalxVDpkTik6JZ6UL/DFmtorNq3HO Zixoa5Q7xjaRJvj42inZe5gnNonu10HyRk/BhPrsQoxN7NIkEBbUrVvT9 dIttKUz6UJ+8D/Kh89EHoa4H/sgdMaoY0MZOJ/lUSCVPgThPab9MaOwKX NcK0JtdGBF3pkqQdyMHdNZbA32PAXSJEdP9m5rTY+xjdGMPTcJyyLI7Zf i1pwlzO5tLOsr6l1iwvwFgZjbyTFd8PH7fBDezvitwh0ZzH/car+yedq8 Q==; X-IronPort-AV: E=Sophos;i="5.98,282,1673884800"; d="scan'208";a="226270636" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 23 Mar 2023 06:34:38 +0800 IronPort-SDR: c937AV50A1jo+OU6XO84EbRL3lcKRAZewAwDSm76NkYiJShh0ejbRSUp0kO7eZA3zPMamr0lRa REkvj9I6bq/YG8xzpDQOb7t1cGQ9S0PiPsMdRRPpHPQwcO944Ukn8QYwseUoQRE42v/MsC3YsB 5tOfQrbuPmV4qYmvQhw56f4v/FdkHnApD2umNZJ3uNTfKtDvJsxATwm/EiKaXN00/bbl9XRv8f 1w8N8JWCpp+AphzQobMGfddXode2dt2Mbwng9QSZpoEZwylhP8DglguoDxRQBml4e0FiHV8lk+ Bb4= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Mar 2023 14:45:14 -0700 IronPort-SDR: pNiz6BZEQ/AAlS1wrdEw8MKYRA2r6VAqpW3QKhvM8anLXFEnF05ZjYfiwmmXflRBPmKA+hPgrp ESkVo1UVr2GFav4BVkXxMu2Xi+EHvVsQ3v98GZyx2nbjrBfvtFUfxLhyKBcF4u2pN0+5nCojUy qJZNydW/wXhzBXrAWwaWt4GbOzg8Pr6KfD5vAftJ+SewLkAakDndl3yHusZyUmm7IsIZyWGFY3 aZ/aEN3qWmVdBIB4Yn2ni16Q5Pokmm0JXfCNTPWT9UTYeIvwlSW9D70Ht9riwfIi+6IID8NHVs nE4= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Mar 2023 15:34:38 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Phjvf1G1mz1RtVq for ; Wed, 22 Mar 2023 15:34:38 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:content-language:references:to :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1679524476; x=1682116477; bh=GRC+ab3cu9sXA63M9BMs8MDzDk/qWTmdP9Y EIETyYIY=; b=e4+/obu7OG3gBlCqgE0TZNoDvNNJ53c7Wzf2eZOgGZoaAxz6Qih 14mmLlPwRVn9OVBw6VsoKUb/63zgQA1yECgO7KDIAzuikqyPecZk/j2OhOs13JNl IXeYHNbSrIc0NDq/37fQlLhnIuYmlDJrEb9WYfIvLSv1SgApA8KMxqYFjxy2tNFD 04vjjnaAzQYiGdLLdL6bS9Asi1LNlh0bE7g6see1mLd3ok+SiYk/RSoPUjfapilT nZQ8ZZXZxMYG1P/nBZHizeNwUF3KTuGvvfV3kAEs/MWI5m+ZTL6cS+MPtPfG2xmq NeM+Yd5PCjRkUVC8vN8G4ZLPu0Bj9TG2qJQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TDQRNW49rJnr for ; Wed, 22 Mar 2023 15:34:36 -0700 (PDT) Received: from [10.225.163.96] (unknown [10.225.163.96]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Phjvb0JL8z1RtVm; Wed, 22 Mar 2023 15:34:34 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 07:34:33 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 00/32] pata_parport-bpck6: rework bpck6 protocol driver To: Ondrej Zary , Sergey Shtylyov Cc: Sudip Mukherjee , Christoph Hellwig , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230307224627.28011-1-linux@zary.sk> <202303181955.41922.linux@zary.sk> <202303221310.44235.linux@zary.sk> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <202303221310.44235.linux@zary.sk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/22/23 21:10, Ondrej Zary wrote: > On Sunday 19 March 2023 21:02:43 Sergey Shtylyov wrote: >> On 3/18/23 9:55 PM, Ondrej Zary wrote: >> >>>>> This patch series simplifies bpck6 code, removing ppc6lnx.c file to match >>>>> the simplicity of other protocol drivers. It also converts the direct >>>>> port I/O access to paraport access functions. This conversion revealed that >>>>> there's no 8-bit and 16-bit EPP support in parport_pc so patch 11 implements >>>>> that. >>>>> >>>>> Tested with Backpack CD-RW 222011 and CD-RW 19350. >>>>> >>>>> Signed-off-by: Ondrej Zary >>>>> --- >>>>> drivers/ata/pata_parport/bpck6.c | 452 +++++++++++++++++++++++++++-------- >>>>> drivers/ata/pata_parport/ppc6lnx.c | 726 --------------------------------------------------------- >>>>> drivers/parport/parport_pc.c | 20 +- >>>>> include/uapi/linux/parport.h | 3 + >>>>> 4 files changed, 370 insertions(+), 831 deletions(-) >>>> >>>> OK, it's finally clear I can't keep up with reviewing 32 patches posted >>>> at once... Luckily, all those patches seem to be dealing with parallel port >>>> control), not the PATA control! Of course, when I volunteered to review the >>>> PATA driver patches, I didn't expect such patch volumes -- I mostly expected >>>> some odd fixes, not a massive driver rework... :-/ >>> >>> So you're going to review the (P)ATA parts (if any) only. >> >> I saw no PATA parts in this patcheset... >> >>> Maybe Sudip (as parport maintainer) could review the parallel port parts? >> >> I have no objections! :-) > > Looks like Sudip does not care. What needs to be done so this can be merged? I will have a look at the series this morning and merge it if I do not see any issues. -- Damien Le Moal Western Digital Research