From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48089C433F5 for ; Thu, 14 Oct 2021 07:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C23960F93 for ; Thu, 14 Oct 2021 07:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbhJNHek (ORCPT ); Thu, 14 Oct 2021 03:34:40 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:45638 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhJNHej (ORCPT ); Thu, 14 Oct 2021 03:34:39 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3151620286; Thu, 14 Oct 2021 07:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634196754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PjkNEVVjVcnP4hxfrSWte/g2gEgbpNDROzH+m+hvbno=; b=QpdvNs60TPbyvV1pd5g9ncCfKB+ob/5GkgR2R3wVl/O8W7CqHWXCGKnolRK5Ifj59iN+10 ripUueOCNLNimq2k5vW9gPCDe0WptlrAQpFRkzNdbeWQVOhrYYHcJ2S8uWFQdU2Plcxz3G JmHsBXdiI35RbTXU6DZb8aoJkrLniNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634196754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PjkNEVVjVcnP4hxfrSWte/g2gEgbpNDROzH+m+hvbno=; b=7gRLpFsQzHxzzZrM5i+z3aO+cnlEWL5QbiACQUbIwmvnp8R3H17KBKdWMK29HorgDEkFdH /yx3MtmStEAWe4DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE12113D3F; Thu, 14 Oct 2021 07:32:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id piMHORHdZ2HIHQAAMHmgww (envelope-from ); Thu, 14 Oct 2021 07:32:33 +0000 Subject: Re: [PATCH 3/7] nfsd/blocklayout: use ->get_unique_id instead of sending SCSI commands To: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" Cc: "J. Bruce Fields" , Chuck Lever , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-nfs@vger.kernel.org References: <20211012120445.861860-1-hch@lst.de> <20211012120445.861860-4-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Thu, 14 Oct 2021 09:32:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20211012120445.861860-4-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 10/12/21 2:04 PM, Christoph Hellwig wrote: > Call the ->get_unique_id method to query the SCSI identifiers. This can > use the cached VPD page in the sd driver instead of sending a command > on every LAYOUTGET. It will also allow to support NVMe based volumes > if the draft for that ever takes off. > > Signed-off-by: Christoph Hellwig > --- > fs/nfsd/Kconfig | 1 - > fs/nfsd/blocklayout.c | 158 +++++++++++------------------------------- > fs/nfsd/nfs4layouts.c | 5 +- > 3 files changed, 44 insertions(+), 120 deletions(-) > Not that I'm an NFS expert, but anyway: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer