From: Hannes Reinecke <hare@suse.de>
To: axboe@kernel.dk, tom.leiming@gmail.com, bvanassche@acm.org,
hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v6 1/5] block: free both rq_map and request
Date: Thu, 7 May 2020 17:09:15 +0200 [thread overview]
Message-ID: <ed7f1076-b0e8-6bf4-28d1-502ce668627f@suse.de> (raw)
In-Reply-To: <e26c4cfa43d586ef83743908ce1c33cc69bb9a2f.1588856361.git.zhangweiping@didiglobal.com>
On 5/7/20 3:03 PM, Weiping Zhang wrote:
> Allocation:
>
> __blk_mq_alloc_rq_map
> blk_mq_alloc_rq_map
> blk_mq_alloc_rq_map
> tags = blk_mq_init_tags : kzalloc_node:
> tags->rqs = kcalloc_node
> tags->static_rqs = kcalloc_node
> blk_mq_alloc_rqs
> p = alloc_pages_node
> tags->static_rqs[i] = p + offset;
>
> Free:
>
> blk_mq_free_rq_map
> kfree(tags->rqs);
> kfree(tags->static_rqs);
> blk_mq_free_tags
> kfree(tags);
>
> The page allocated in blk_mq_alloc_rqs cannot be released,
> so we should use blk_mq_free_map_and_requests here.
>
> blk_mq_free_map_and_requests
> blk_mq_free_rqs
> __free_pages : cleanup for blk_mq_alloc_rqs
> blk_mq_free_rq_map : cleanup for blk_mq_alloc_rq_map
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> block/blk-mq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index a7785df2c944..f789b3e1b3ab 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2995,7 +2995,7 @@ static int __blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
>
> out_unwind:
> while (--i >= 0)
> - blk_mq_free_rq_map(set->tags[i]);
> + blk_mq_free_map_and_requests(set, i);
>
> return -ENOMEM;
> }
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-05-07 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:03 [PATCH v6 0/5] Fix potential kernel panic when increase hardware queue Weiping Zhang
2020-05-07 13:03 ` [PATCH v6 1/5] block: free both rq_map and request Weiping Zhang
2020-05-07 15:09 ` Hannes Reinecke [this message]
2020-05-07 13:03 ` [PATCH v6 2/5] block: save previous hardware queue count before udpate Weiping Zhang
2020-05-07 15:09 ` Hannes Reinecke
2020-05-07 13:04 ` [PATCH v6 3/5] block: alloc map and request for new hardware queue Weiping Zhang
2020-05-07 15:11 ` Hannes Reinecke
2020-05-07 13:04 ` [PATCH v6 4/5] block: rename __blk_mq_alloc_rq_map Weiping Zhang
2020-05-07 15:12 ` Hannes Reinecke
2020-05-07 13:04 ` [PATCH v6 5/5] block: rename blk_mq_alloc_rq_maps Weiping Zhang
2020-05-07 15:12 ` Hannes Reinecke
2020-05-07 13:43 ` [PATCH v6 0/5] Fix potential kernel panic when increase hardware queue Christoph Hellwig
2020-05-07 18:31 ` Jens Axboe
2020-05-12 1:30 ` Bart Van Assche
2020-05-12 12:09 ` Weiping Zhang
2020-05-12 12:20 ` Weiping Zhang
2020-05-12 23:08 ` Bart Van Assche
2020-05-13 0:43 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7f1076-b0e8-6bf4-28d1-502ce668627f@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).