From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-scsi-owner@vger.kernel.org>
Subject: Re: [PATCH 4/4] mtd: nand: nandsim: convert to memalloc_noreclaim_*()
To: Michal Hocko <mhocko@kernel.org>, Vlastimil Babka <vbabka@suse.cz>
References: <20170405074700.29871-1-vbabka@suse.cz>
 <20170405074700.29871-5-vbabka@suse.cz>
 <20170405113157.GM6035@dhcp22.suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Mel Gorman <mgorman@techsingularity.net>,
        Johannes Weiner <hannes@cmpxchg.org>,
        linux-block@vger.kernel.org, nbd-general@lists.sourceforge.net,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        netdev@vger.kernel.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Adrian Hunter <adrian.hunter@intel.com>
From: Richard Weinberger <richard@nod.at>
Message-ID: <ee6649ed-b0e8-1c59-c193-d1688fdfe7f5@nod.at>
Date: Wed, 5 Apr 2017 13:36:22 +0200
MIME-Version: 1.0
In-Reply-To: <20170405113157.GM6035@dhcp22.suse.cz>
Content-Type: text/plain; charset=windows-1252
Sender: linux-scsi-owner@vger.kernel.org
List-ID: <linux-block@vger.kernel.org>

Michal,

Am 05.04.2017 um 13:31 schrieb Michal Hocko:
> On Wed 05-04-17 09:47:00, Vlastimil Babka wrote:
>> Nandsim has own functions set_memalloc() and clear_memalloc() for robust
>> setting and clearing of PF_MEMALLOC. Replace them by the new generic helpers.
>> No functional change.
> 
> This one smells like an abuser. Why the hell should read/write path
> touch memory reserves at all!

Could be. Let's ask Adrian, AFAIK he wrote that code.
Adrian, can you please clarify why nandsim needs to play with PF_MEMALLOC?

Thanks,
//richard