From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554C4C3F2CE for ; Sun, 1 Mar 2020 02:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3746C24672 for ; Sun, 1 Mar 2020 02:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbgCACMo (ORCPT ); Sat, 29 Feb 2020 21:12:44 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:43176 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbgCACMo (ORCPT ); Sat, 29 Feb 2020 21:12:44 -0500 Received: by mail-pf1-f193.google.com with SMTP id s1so3738638pfh.10; Sat, 29 Feb 2020 18:12:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nMhy4PQO+gzPr6w4E8+cPuZayIuplQlnnOtodz7oz1s=; b=tNBNYwduY4az8z8mxZJPJgQVrelqravFSFScl0vbX/C1vKA/by15ALH9aCyk6pyYDm gNdc0127xedqE3jeANsmyDoLKTrgUoxUSagqPYk9veFs5SMQKmuNRiy8cLHCYXRKLIa+ IbI8rKXG9zT91JGs8XWudwHPxp3+xtAIhoVU/2t3O4OLe2drR5amLsF1BGucOfUskKaW Ct5QTCI0LIVXHOyr/ONrvB2AYZqG69nmYY9DCgiAs2/u2Ibw/2WpLlyCSFK7xh1pJLoc AxsdsVNSB7wW5OcExKTvi0nsRhvN8I2yJGUkvEkcO+Gdlad+RQz8v/flba8r1oiUazSV ENPQ== X-Gm-Message-State: ANhLgQ2Wp/i9VTSZiSm6piKiQhdf2E0tMISFO+JKQVQGAHd3mh8eF2+B uc6pXffhSMqa0h2PE1dygBM= X-Google-Smtp-Source: ADFU+vucKPoZN+nHBHurHWIOq22B3/ABPAosVMubfjFU67i6QhhTAIAmBorXabqYMLjGniYdQDUVzw== X-Received: by 2002:a62:848e:: with SMTP id k136mr3697445pfd.227.1583028761573; Sat, 29 Feb 2020 18:12:41 -0800 (PST) Received: from ?IPv6:2601:647:4000:d7:bd83:6f94:8c5:942d? ([2601:647:4000:d7:bd83:6f94:8c5:942d]) by smtp.gmail.com with ESMTPSA id z127sm15225663pgb.64.2020.02.29.18.12.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Feb 2020 18:12:40 -0800 (PST) Subject: Re: [PATCH v9 15/25] block/rnbd: private headers with rnbd protocol structs and helpers To: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org Cc: axboe@kernel.dk, hch@infradead.org, sagi@grimberg.me, leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca, danil.kipnis@cloud.ionos.com, jinpu.wang@cloud.ionos.com, rpenyaev@suse.de, pankaj.gupta@cloud.ionos.com References: <20200221104721.350-1-jinpuwang@gmail.com> <20200221104721.350-16-jinpuwang@gmail.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Sat, 29 Feb 2020 18:12:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221104721.350-16-jinpuwang@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020-02-21 02:47, Jack Wang wrote: > +/** > + * struct rnbd_msg_hdr - header of RNBD messages > + * @type: Message type, valid values see: enum rnbd_msg_types > + */ > +struct rnbd_msg_hdr { > + __le16 type; > + __le16 __padding; > +}; Please add a BUILD_BUG_ON() somewhere that checks the size of the structures that represent the wire protocol. > +static inline u32 rnbd_op(u32 flags) > +{ > + return (flags & RNBD_OP_MASK); > +} > + > +static inline u32 rnbd_flags(u32 flags) > +{ > + return (flags & ~RNBD_OP_MASK); > +} No parentheses around returned values please. Thanks, Bart.