From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
David Sterba <dsterba@suse.com>
Cc: Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 5/7] btrfs, block: move REQ_CGROUP_PUNT to btrfs
Date: Mon, 27 Mar 2023 19:15:11 -0600 [thread overview]
Message-ID: <f1b3f0c2-f08a-a432-f0c5-6223a59e671a@kernel.dk> (raw)
In-Reply-To: <20230327004954.728797-6-hch@lst.de>
On 3/26/23 6:49?PM, Christoph Hellwig wrote:
> REQ_CGROUP_PUNT is a bit annoying as it is hard to follow and adds
> a branch to the bio submission hot path. To fix this, export
> blkcg_punt_bio_submit and let btrfs call it directly. Add a new
> REQ_FS_PRIVATE flag for btrfs to indicate to it's own low-level
> bio submission code that a punt to the cgroup submission helper
> is required.
Looks good, and nice to remove more cruft from the generic
submission path:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2023-03-28 1:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 0:49 move bio cgroup punting into btrfs Christoph Hellwig
2023-03-27 0:49 ` [PATCH 1/7] btrfs: move kthread_associate_blkcg out of btrfs_submit_compressed_write Christoph Hellwig
2023-03-27 0:49 ` [PATCH 2/7] btrfs: don't free the async_extent in submit_uncompressed_range Christoph Hellwig
2023-03-27 0:49 ` [PATCH 3/7] btrfs: also use kthread_associate_blkcg for uncompressible ranges Christoph Hellwig
2023-03-27 0:49 ` [PATCH 4/7] btrfs, mm: remove the punt_to_cgroup field in struct writeback_control Christoph Hellwig
2023-03-27 0:49 ` [PATCH 5/7] btrfs, block: move REQ_CGROUP_PUNT to btrfs Christoph Hellwig
2023-03-28 1:15 ` Jens Axboe [this message]
2023-03-27 0:49 ` [PATCH 6/7] block: async_bio_lock does not need to be bh-safe Christoph Hellwig
2023-03-27 23:31 ` Jens Axboe
2023-03-27 0:49 ` [PATCH 7/7] block: make blkcg_punt_bio_submit optional Christoph Hellwig
2023-03-27 23:32 ` Jens Axboe
2023-03-27 23:18 ` move bio cgroup punting into btrfs David Sterba
2023-03-31 17:25 ` David Sterba
2023-03-28 21:18 ` Chris Mason
2023-03-28 23:34 ` Christoph Hellwig
2023-03-29 19:16 ` Tejun Heo
2023-03-30 0:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b3f0c2-f08a-a432-f0c5-6223a59e671a@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).