From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com
Cc: linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: remove VIRTIO_BLK_F_SCSI support
Date: Fri, 13 Dec 2019 10:55:35 +0100 [thread overview]
Message-ID: <f6b110d8-2f13-94e9-0b11-92e2c103f7d6@suse.de> (raw)
In-Reply-To: <20191212163719.28432-1-hch@lst.de>
On 12/12/19 5:37 PM, Christoph Hellwig wrote:
> Since the need for a special flag to support SCSI passthrough on a
> block device was added in May 2017 the SCSI passthrough support in
> virtio-blk has been disabled. It has always been a bad idea
> (just ask the original author..) and we have virtio-scsi for proper
> passthrough. The feature also never made it into the virtio 1.0
> or later specifications.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/powerpc/configs/guest.config | 1 -
> drivers/block/Kconfig | 10 ---
> drivers/block/virtio_blk.c | 115 +-----------------------------
> 3 files changed, 1 insertion(+), 125 deletions(-)
>
I'm all for it.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2019-12-13 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:37 [PATCH] virtio-blk: remove VIRTIO_BLK_F_SCSI support Christoph Hellwig
2019-12-13 9:55 ` Hannes Reinecke [this message]
2019-12-13 11:12 ` Stefan Hajnoczi
2019-12-13 12:24 ` Michael S. Tsirkin
2020-01-05 13:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b110d8-2f13-94e9-0b11-92e2c103f7d6@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).