From: Jens Axboe <axboe@kernel.dk>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Philip Kelleher <pjk1939@linux.ibm.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] rsxx: Use struct_size() in vmalloc()
Date: Fri, 14 May 2021 09:00:56 -0600 [thread overview]
Message-ID: <fb567b7b-5ea4-fe8b-52cc-f148ff6a61b7@kernel.dk> (raw)
In-Reply-To: <20210513203730.GA212128@embeddedor>
On 5/13/21 2:37 PM, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows
> that, in the worst scenario, could lead to heap overflows.
>
> This code was detected with the help of Coccinelle and, audited and
> fixed manually.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-05-14 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 20:37 [PATCH][next] rsxx: Use struct_size() in vmalloc() Gustavo A. R. Silva
2021-05-14 15:00 ` Jens Axboe [this message]
2021-05-15 0:03 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb567b7b-5ea4-fe8b-52cc-f148ff6a61b7@kernel.dk \
--to=axboe@kernel.dk \
--cc=gustavoars@kernel.org \
--cc=josh.h.morris@us.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjk1939@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).