From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADF9C07E9A for ; Mon, 5 Jul 2021 03:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A013661375 for ; Mon, 5 Jul 2021 03:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbhGEEC0 (ORCPT ); Mon, 5 Jul 2021 00:02:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42771 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbhGEECZ (ORCPT ); Mon, 5 Jul 2021 00:02:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625457589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WXgO0oXmvf/9A/1qL8w68Z6/mTqGpM66mMODKwc4Vbo=; b=Y/9V0wYz2D2UIwkSGFcyEkae9nfVeIZazhC/ybBGmZ76jxea1C92woiXcSOen/XYnaM1Cp C9VS2LKHpIHzhdR/n/vx5Td5FeH4LQY30XVvFNLLIrT6SZKq1e/wUxyi9dhVYn23U6qzGh sQcwgICOrDsmIY0YNtWNTGQhN24rcKE= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-6gZ4_6rBNzaPB9T7ss63-g-1; Sun, 04 Jul 2021 23:59:48 -0400 X-MC-Unique: 6gZ4_6rBNzaPB9T7ss63-g-1 Received: by mail-pf1-f200.google.com with SMTP id q10-20020a056a0002aab02903096dd9b65eso2051547pfs.17 for ; Sun, 04 Jul 2021 20:59:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WXgO0oXmvf/9A/1qL8w68Z6/mTqGpM66mMODKwc4Vbo=; b=hHQi+ai4ETO+tNFDgKDdZMU+x+CzegUpPMo6xApVC4TKNhc/nOkvzzdaNpvYHOw5k0 vFBnO10yJ/gP9gv13juaGcD7pb7r+YNjYRtpeivZ6XD983u4gi96XKUEwMzMtYipFrPp BJG/OQM4ANWTfow3bPVoWfI39Rxz+3QHzF+7Yruof2Eaxsn1aICiGfeVMjglPoMmZCk0 6kXsaSFLTf+bFjQa6z/lbuKLxYQpyin10gm2UoxoXyi0nUb/wcFVl3XkuORJINd/9mbg /rXFqo0a7+AxdK74thMXrR7wKSFu2LtMRIz/k3vHEjN8YvxMZ3KhxvzUxyPcnrxhvk8/ sqTg== X-Gm-Message-State: AOAM53107NMfcPNfGnSP/cU6O9dO25J3dLhL+EdN6ej6P8gZBpDRgH1f 0WsOEvFPovWxuW/01dnxKjYsxKfgp+1j/WjvnHKPtD551uBRZMTaMm6EsxRO27rY2JhlAJWVs2g cPgf1ke9vyWOA/vzsOUGV60A= X-Received: by 2002:a17:90a:af90:: with SMTP id w16mr13185177pjq.129.1625457587009; Sun, 04 Jul 2021 20:59:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7m1tdef3U/fD1ZeJXGh6nhQJM7pMQfOcmUl03cSHKc5dhYUnHwmNe0pBMkiHdPgpxcvo9fQ== X-Received: by 2002:a17:90a:af90:: with SMTP id w16mr13185164pjq.129.1625457586781; Sun, 04 Jul 2021 20:59:46 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k9sm526132pfu.100.2021.07.04.20.59.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 20:59:46 -0700 (PDT) Subject: Re: [PATCH V2 5/6] virtio: add one field into virtio_device for recording if device uses managed irq To: Ming Lei , Jens Axboe , Christoph Hellwig , "Martin K . Petersen" , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Cc: Sagi Grimberg , Daniel Wagner , Wen Xiong , John Garry , Hannes Reinecke , Keith Busch , Damien Le Moal , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org References: <20210702150555.2401722-1-ming.lei@redhat.com> <20210702150555.2401722-6-ming.lei@redhat.com> From: Jason Wang Message-ID: Date: Mon, 5 Jul 2021 11:59:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702150555.2401722-6-ming.lei@redhat.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org ÔÚ 2021/7/2 ÏÂÎç11:05, Ming Lei дµÀ: > blk-mq needs to know if the device uses managed irq, so add one field > to virtio_device for recording if device uses managed irq. > > If the driver use managed irq, this flag has to be set so it can be > passed to blk-mq. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc:virtualization@lists.linux-foundation.org > Signed-off-by: Ming Lei > --- > drivers/block/virtio_blk.c | 2 ++ > drivers/scsi/virtio_scsi.c | 1 + > drivers/virtio/virtio_pci_common.c | 1 + > include/linux/virtio.h | 1 + > 4 files changed, 5 insertions(+) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index e4bd3b1fc3c2..33b9c80ac475 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -764,6 +764,8 @@ static int virtblk_probe(struct virtio_device *vdev) > vblk->tag_set.queue_depth = queue_depth; > vblk->tag_set.numa_node = NUMA_NO_NODE; > vblk->tag_set.flags = BLK_MQ_F_SHOULD_MERGE; > + if (vdev->use_managed_irq) > + vblk->tag_set.flags |= BLK_MQ_F_MANAGED_IRQ; I'm not familiar with blk mq. But the name is kind of confusing, I guess "BLK_MQ_F_AFFINITY_MANAGED_IRQ" is better? (Consider we had "IRQD_AFFINITY_MANAGED") This helps me to differ this from the devres (device managed IRQ) at least. Thanks