From: Jens Axboe <axboe@kernel.dk>
To: Paolo Valente <paolo.valente@linaro.org>,
liubaozhu <liubaozhu@uniontech.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/bfq: the delta_from_first should be ns rather than us
Date: Wed, 21 Jul 2021 10:19:22 -0600 [thread overview]
Message-ID: <fd992897-2ef6-f574-eb07-5223fc6b1af5@kernel.dk> (raw)
In-Reply-To: <3A3B282C-FA5D-43F3-9C78-5E257C93A835@linaro.org>
On 7/21/21 1:54 AM, Paolo Valente wrote:
>
>
>> Il giorno 21 lug 2021, alle ore 08:30, liubaozhu <liubaozhu@uniontech.com <mailto:liubaozhu@uniontech.com>> ha scritto:
>>
>> In the block/bfq-iosched.c,the function bfq_update_peak_rate(),
>> bfqd->delta_from_first = now_ns - bfqd->first_dispatch,
>> according to the subtraction operation here,now_ns is ns,
>> and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should be ns.
>>
>
> Correct!
>
> Acked-by: Paolo Valente <paolo.valente@linaro.org <mailto:paolo.valente@linaro.org>>
Just pick this up for your 5.15 series and include it in that.
--
Jens Axboe
prev parent reply other threads:[~2021-07-21 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:30 [PATCH] block/bfq: the delta_from_first should be ns rather than us liubaozhu
2021-07-21 7:56 ` Paolo Valente
[not found] ` <3A3B282C-FA5D-43F3-9C78-5E257C93A835@linaro.org>
2021-07-21 16:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd992897-2ef6-f574-eb07-5223fc6b1af5@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaozhu@uniontech.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).