linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] null_blk: Fix a NULL pointer dereference
Date: Wed, 22 Sep 2021 11:03:45 -0700	[thread overview]
Message-ID: <fdf80121-35aa-0295-8614-54247fd12686@acm.org> (raw)
In-Reply-To: <d8c3e376-145e-f29a-3cf2-210fae4c8884@kernel.dk>

On 9/22/21 10:54 AM, Jens Axboe wrote:
> On 9/22/21 11:50 AM, Bart Van Assche wrote:
>> Skip queue mapping for shared tag sets. This patch fixes the following bug:
>>
>> ==================================================================
>> BUG: KASAN: null-ptr-deref in null_map_queues+0x131/0x1a0 [null_blk]
>> Read of size 8 at addr 0000000000000000 by task modprobe/4320
>>
>> CPU: 9 PID: 4320 Comm: modprobe Tainted: G         E     5.15.0-rc2-dbg+ #2
>> Call Trace:
>>   show_stack+0x52/0x58
>>   dump_stack_lvl+0x49/0x5e
>>   kasan_report.cold+0x64/0xdb
>>   __asan_load8+0x69/0x90
>>   null_map_queues+0x131/0x1a0 [null_blk]
>>   blk_mq_update_queue_map+0x122/0x1a0
>>   blk_mq_alloc_tag_set+0x1e8/0x570
>>   null_init_tag_set+0x197/0x220 [null_blk]
>>   null_init+0x1dc/0x1000 [null_blk]
>>   do_one_initcall+0xc7/0x440
>>   do_init_module+0x10a/0x3d0
>>   load_module+0x115c/0x1220
>>   __do_sys_finit_module+0x124/0x1a0
>>   __x64_sys_finit_module+0x42/0x50
>>   do_syscall_64+0x35/0xb0
>>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> Thanks Bart, do you mind if I fold this one in? I can add a Fixes-by tag
> as well.

Hi Jens,

That sounds good to me. In case this patch would be retained: the word "Skip"
in the description should be changed into "Fix".

Thanks,

Bart.



  reply	other threads:[~2021-09-22 18:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 17:50 [PATCH] null_blk: Fix a NULL pointer dereference Bart Van Assche
2021-09-22 17:54 ` Jens Axboe
2021-09-22 18:03   ` Bart Van Assche [this message]
2021-09-22 18:26     ` Bart Van Assche
2021-09-23 16:04       ` Jens Axboe
2021-09-23 16:22         ` Bart Van Assche
2021-09-23 16:39           ` Jens Axboe
2021-09-23 17:51             ` Bart Van Assche
2021-09-23 17:55               ` Jens Axboe
2021-09-23 18:53                 ` Jens Axboe
2021-09-23 19:16                   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdf80121-35aa-0295-8614-54247fd12686@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).