From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB9AC04EB9 for ; Wed, 5 Dec 2018 15:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07FFB2084C for ; Wed, 5 Dec 2018 15:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07FFB2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727242AbeLEP10 (ORCPT ); Wed, 5 Dec 2018 10:27:26 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:16082 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727195AbeLEP10 (ORCPT ); Wed, 5 Dec 2018 10:27:26 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 4BDBADA7FDF17; Wed, 5 Dec 2018 23:27:21 +0800 (CST) Received: from [127.0.0.1] (10.202.226.41) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.408.0; Wed, 5 Dec 2018 23:27:14 +0800 Subject: Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT To: "Martin K. Petersen" References: <5d9bf51d-1ef9-b948-2168-9e7526d77225@hisilicon.com> <20181127130811.GA2780@ming.t460p> <6c573f36-60d8-0631-e9ac-dacd72f6c8ad@hisilicon.com> <20181130011935.GA7573@ming.t460p> <45193ec6-6398-3953-4833-88ca2057971a@huawei.com> CC: Ming Lei , "chenxiang (M)" , "James E.J. Bottomley" , "linux-scsi@vger.kernel.org" , "linux-block@vger.kernel.org" , Linuxarm , Steffen Maier From: John Garry Message-ID: Date: Wed, 5 Dec 2018 15:27:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-CFilter-Loop: Reflected Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 05/12/2018 02:22, Martin K. Petersen wrote: > Hi Martin, > John, > >> OK, great. Happy to help. So far we have hisi_sas fio issue to go on >> plus knowledge that this issue seems to be exposed/triggered by >> enabling SCSI MQ. > > I'll have to go revisit the archives for your exact fio bits. > > But I successfully ran our DIX/T10 PI qualification tooling without any > errors on the latest SCSI tree. On both scsi_debug and FC hardware. I'm not fimilar with this tooling. Is it internal to your company? Unfortunately it seems that no other SAS HBA kernel driver supports DIX, so we have nothing to test against for this transport. > >> My colleague chenxiang also tried DIF on 3008 with our same platform, >> and we are seeing an issue there also; here's a snippet: > > Reproduced this. Turns out to be a recently introduced bug that > exclusively affects DIF-only setups (so primarily mpt3sas due to lack of > DIX support). It's a regression caused by a commit that went in through > block a few months ago. I'll send a patch... > ok, great. thanks, John