From: Jiri Kosina <jikos@kernel.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "pavel@ucw.cz" <pavel@ucw.cz>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"len.brown@intel.com" <len.brown@intel.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"ONeukum@suse.com" <ONeukum@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nborisov@suse.com" <nborisov@suse.com>,
"oleg.b.antonyan@gmail.com" <oleg.b.antonyan@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"jgross@suse.com" <jgross@suse.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"todd.e.brandt@linux.intel.com" <todd.e.brandt@linux.intel.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [RFC 5/5] pm: remove kernel thread freezing
Date: Tue, 3 Oct 2017 22:51:50 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1710032248470.17517@jbgna.fhfr.qr> (raw)
In-Reply-To: <nycvar.YFH.7.76.1710032215140.17517@jbgna.fhfr.qr>
On Tue, 3 Oct 2017, Jiri Kosina wrote:
> > What about the many drivers outside filesystems that use the
> > set_freezable() / try_to_freeze() / wait_event_freezable() API?
>
> Many/most of them are just completely bogus and pointless.
More specifically -- they don't really care at all whether they get
scheduled out exactly at the try_to_freeze() point; they are perfectly
happy being scheduled out at any other scheduling point, and land on
runqueue after the resume has been completed.
Sure, certain drivers need to take action when system is undergoing
hibernation/suspend. But that's what PM callbacks are for, not kthread
hibernation.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2017-10-03 20:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 18:53 [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 1/5] fs: add iterate_supers_reverse() Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 2/5] fs: freeze on suspend and thaw on resume Luis R. Rodriguez
2017-10-03 20:02 ` Bart Van Assche
2017-10-03 20:23 ` Luis R. Rodriguez
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:39 ` Luis R. Rodriguez
2017-10-03 20:06 ` Jiri Kosina
2017-10-03 20:58 ` Dave Chinner
2017-10-03 21:16 ` Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 3/5] xfs: allow fs freeze on suspend/hibernation Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 4/5] ext4: add fs freezing support " Luis R. Rodriguez
2017-10-03 19:59 ` Theodore Ts'o
2017-10-03 20:13 ` Luis R. Rodriguez
2017-10-04 1:42 ` Theodore Ts'o
2017-10-04 7:05 ` Dave Chinner
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 16:48 ` Theodore Ts'o
2017-10-04 22:22 ` Dave Chinner
2017-10-03 18:53 ` [RFC 5/5] pm: remove kernel thread freezing Luis R. Rodriguez
2017-10-03 18:59 ` Rafael J. Wysocki
2017-10-03 21:15 ` Rafael J. Wysocki
2017-10-04 0:47 ` Luis R. Rodriguez
2017-10-04 1:03 ` Bart Van Assche
2017-11-29 23:05 ` Luis R. Rodriguez
2017-10-04 7:18 ` Dave Chinner
2017-10-03 20:12 ` Pavel Machek
2017-10-03 20:15 ` Jiri Kosina
2017-10-03 20:21 ` Pavel Machek
2017-10-03 20:38 ` Jiri Kosina
2017-10-03 20:41 ` Rafael J. Wysocki
2017-10-03 20:57 ` Pavel Machek
2017-10-03 21:00 ` Jiri Kosina
2017-10-03 21:09 ` Shuah Khan
2017-10-03 21:18 ` Luis R. Rodriguez
2017-10-03 20:49 ` Luis R. Rodriguez
2017-10-06 12:07 ` Pavel Machek
2017-10-06 12:54 ` Theodore Ts'o
2017-10-03 20:13 ` Bart Van Assche
2017-10-03 20:17 ` Jiri Kosina
2017-10-03 20:21 ` Bart Van Assche
2017-10-03 20:24 ` Jiri Kosina
2017-10-03 20:27 ` Luis R. Rodriguez
2017-10-03 20:51 ` Jiri Kosina [this message]
2017-10-03 21:04 ` Dave Chinner
2017-10-03 21:07 ` Luis R. Rodriguez
2017-10-04 6:07 ` Hannes Reinecke
2017-10-03 19:33 ` [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Ming Lei
2017-10-03 20:05 ` Luis R. Rodriguez
2017-10-03 20:47 ` Matthew Wilcox
2017-10-03 20:54 ` Luis R. Rodriguez
2017-10-03 20:59 ` Bart Van Assche
2017-10-04 15:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1710032248470.17517@jbgna.fhfr.qr \
--to=jikos@kernel.org \
--cc=Bart.VanAssche@wdc.com \
--cc=ONeukum@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=jgross@suse.com \
--cc=len.brown@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=nborisov@suse.com \
--cc=oleg.b.antonyan@gmail.com \
--cc=oleksandr@natalenko.name \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=todd.e.brandt@linux.intel.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).