* [PATCH -next] floppy: remove set but not used variable 'q'
@ 2019-02-18 8:42 YueHaibing
2019-02-19 9:01 ` Jiri Kosina
2019-02-28 21:06 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-02-18 8:42 UTC (permalink / raw)
To: Jiri Kosina, Jens Axboe; +Cc: YueHaibing, linux-block, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/block/floppy.c: In function 'request_done':
drivers/block/floppy.c:2233:24: warning:
variable 'q' set but not used [-Wunused-but-set-variable]
It's never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/block/floppy.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 55481b40df9a..95f608d1a098 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2230,7 +2230,6 @@ static void floppy_end_request(struct request *req, blk_status_t error)
static void request_done(int uptodate)
{
struct request *req = current_req;
- struct request_queue *q;
int block;
char msg[sizeof("request done ") + sizeof(int) * 3];
@@ -2243,8 +2242,6 @@ static void request_done(int uptodate)
return;
}
- q = req->q;
-
if (uptodate) {
/* maintain values for invalidation on geometry
* change */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] floppy: remove set but not used variable 'q'
2019-02-18 8:42 [PATCH -next] floppy: remove set but not used variable 'q' YueHaibing
@ 2019-02-19 9:01 ` Jiri Kosina
2019-02-28 21:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2019-02-19 9:01 UTC (permalink / raw)
To: YueHaibing; +Cc: Jens Axboe, linux-block, kernel-janitors
On Mon, 18 Feb 2019, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/block/floppy.c: In function 'request_done':
> drivers/block/floppy.c:2233:24: warning:
> variable 'q' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Jens, could you please take this through your tree?
Thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] floppy: remove set but not used variable 'q'
2019-02-18 8:42 [PATCH -next] floppy: remove set but not used variable 'q' YueHaibing
2019-02-19 9:01 ` Jiri Kosina
@ 2019-02-28 21:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-02-28 21:06 UTC (permalink / raw)
To: YueHaibing, Jiri Kosina; +Cc: linux-block, kernel-janitors
On 2/18/19 1:42 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/block/floppy.c: In function 'request_done':
> drivers/block/floppy.c:2233:24: warning:
> variable 'q' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-28 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 8:42 [PATCH -next] floppy: remove set but not used variable 'q' YueHaibing
2019-02-19 9:01 ` Jiri Kosina
2019-02-28 21:06 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).