From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4304C4320A for ; Mon, 16 Aug 2021 07:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E55A61AA3 for ; Mon, 16 Aug 2021 07:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233723AbhHPHSH (ORCPT ); Mon, 16 Aug 2021 03:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233906AbhHPHSH (ORCPT ); Mon, 16 Aug 2021 03:18:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71D1161A86; Mon, 16 Aug 2021 07:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629098256; bh=V3I7Bd7jxAfVHg8y2QMOjUbjW5mcFbPEbMgjJfYkyiA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hQ2iOmkT6EgOJa7XEQDWU1z3CDkY1B9U8B0uXz8tujK1SVEIJFbXqZ9NM3JYBR9aZ nFVo4bHuMSuJE2I7ipU2GZnMheGRMmD6bI7hIg9AY4vgPxlmaAs1skjbBWjG4nKST5 kfA1DejFZGFn4TbntzkkxdMdtBCMBD4q6x/bB/FYtZS7CT2sCqbiH3UXvNTq3VTSDT YikHySeMMxJt7lUUG/+AvxKAJQrrwyndEpF4P8YAtSvIFC9mAz+GLYBXArF30STrA6 NL2Qv/BvveL/9shn2FTTc7q7aY7drkOhcHXKSLaRSl1FjothGoVrz5P2xWoUh0qRnh +smZIO+VNYMXg== Date: Mon, 16 Aug 2021 09:17:30 +0200 (CEST) From: Jiri Kosina To: Denis Efremov cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, Mark Hounschell , Wim Osterholt , Kurt Garloff , stable@vger.kernel.org Subject: Re: [PATCH] Revert "floppy: reintroduce O_NDELAY fix" In-Reply-To: <20210808074246.33449-1-efremov@linux.com> Message-ID: References: <20210808074246.33449-1-efremov@linux.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, 8 Aug 2021, Denis Efremov wrote: > The patch breaks userspace implementations (e.g. fdutils) and introduces > regressions in behaviour. Previously, it was possible to O_NDELAY open a > floppy device with no media inserted or with write protected media without > an error. Some userspace tools use this particular behavior for probing. > > It's not the first time when we revert this patch. Previous revert is in > commit f2791e7eadf4 (Revert "floppy: refactor open() flags handling"). > > This reverts commit 8a0c014cd20516ade9654fc13b51345ec58e7be8. By reverting it you bring back the bugs that were fixed by it -- e.g. the possibility to livelock mmap() on the returned fd to keep waiting on the page unlock bit forever, or the functionality bug reported at [1], and likely others. [1] https://bugzilla.suse.com/show_bug.cgi?id=1181018 -- Jiri Kosina SUSE Labs