linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
	linux-block@vger.kernel.org
Subject: Re: [patch] io_uring: don't allow duplicate registrations
Date: Wed, 16 Jan 2019 20:31:30 -0500	[thread overview]
Message-ID: <x4936pshxxp.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <9965e26b-1490-7a18-e112-0d2318b8b23f@kernel.dk> (Jens Axboe's message of "Wed, 16 Jan 2019 18:23:16 -0700")

Jens Axboe <axboe@kernel.dk> writes:

> On 1/16/19 5:50 PM, Jeff Moyer wrote:
>> Hi, Jens,
>> 
>> It looks to me like calling io_uring_register more than once (for either
>> IORING_REGISTER_BUFFERS or IORING_REGISTER_FILES) will leak the
>> references taken in previous calls.
>
> Oops, thanks for that. Let's make it -EBUSY though, everything ends up
> being -EINVAL and that sometimes makes it hard for an application to
> figure out wtf is going on.

Sounds good.

> I also added -EINVAL for unregister when not already setup.

Yep, I saw that.

-Jeff

  reply	other threads:[~2019-01-17  1:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  0:50 [patch] io_uring: don't allow duplicate registrations Jeff Moyer
2019-01-17  1:23 ` Jens Axboe
2019-01-17  1:31   ` Jeff Moyer [this message]
2019-01-17  1:33     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x4936pshxxp.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-aio@kvack.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).