From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Roman Penyaev <rpenyaev@suse.de>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-block@vger.kernel.org, linux-arch@vger.kernel.org,
hch@lst.de, avi@scylladb.com, linux-block-owner@vger.kernel.org
Subject: Re: [PATCH 05/15] Add io_uring IO interface
Date: Thu, 17 Jan 2019 15:03:41 -0500 [thread overview]
Message-ID: <x49bm4f831e.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <af41e99c-54f2-a94c-a876-d673fe477e0a@kernel.dk> (Jens Axboe's message of "Thu, 17 Jan 2019 07:01:07 -0700")
Jens Axboe <axboe@kernel.dk> writes:
> On 1/17/19 5:48 AM, Roman Penyaev wrote:
>> On 2019-01-16 18:49, Jens Axboe wrote:
>>
>> [...]
>>
>>> +static int io_allocate_scq_urings(struct io_ring_ctx *ctx,
>>> + struct io_uring_params *p)
>>> +{
>>> + struct io_sq_ring *sq_ring;
>>> + struct io_cq_ring *cq_ring;
>>> + size_t size;
>>> + int ret;
>>> +
>>> + sq_ring = io_mem_alloc(struct_size(sq_ring, array, p->sq_entries));
>>
>> It seems that sq_entries, cq_entries are not limited at all. Can nasty
>> app consume a lot of kernel pages calling io_setup_uring() from a loop
>> passing random entries number? (or even better: decreasing entries
>> number,
>> in order to consume all pages orders with min number of loops).
>
> Yes, that's an oversight, we should have a limit in place. I'll add that.
Can we charge the ring memory to the RLIMIT_MEMLOCK as well? I'd prefer
not to repeat the mistake of fs.aio-max-nr.
-Jeff
next prev parent reply other threads:[~2019-01-17 20:03 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 17:49 [PATCHSET v5] io_uring IO interface Jens Axboe
2019-01-16 17:49 ` [PATCH 01/15] fs: add an iopoll method to struct file_operations Jens Axboe
2019-01-16 17:49 ` [PATCH 02/15] block: wire up block device iopoll method Jens Axboe
2019-01-16 17:49 ` [PATCH 03/15] block: add bio_set_polled() helper Jens Axboe
2019-01-16 17:49 ` [PATCH 04/15] iomap: wire up the iopoll method Jens Axboe
2019-01-16 17:49 ` [PATCH 05/15] Add io_uring IO interface Jens Axboe
2019-01-17 12:02 ` Roman Penyaev
2019-01-17 13:54 ` Jens Axboe
2019-01-17 14:34 ` Roman Penyaev
2019-01-17 14:54 ` Jens Axboe
2019-01-17 15:19 ` Roman Penyaev
2019-01-17 12:48 ` Roman Penyaev
2019-01-17 14:01 ` Jens Axboe
2019-01-17 20:03 ` Jeff Moyer [this message]
2019-01-17 20:09 ` Jens Axboe
2019-01-17 20:14 ` Jens Axboe
2019-01-17 20:50 ` Jeff Moyer
2019-01-17 20:53 ` Jens Axboe
2019-01-17 21:02 ` Jeff Moyer
2019-01-17 21:17 ` Jens Axboe
2019-01-17 21:21 ` Jeff Moyer
2019-01-17 21:27 ` Jens Axboe
2019-01-18 8:23 ` Roman Penyaev
2019-01-16 17:49 ` [PATCH 06/15] io_uring: add fsync support Jens Axboe
2019-01-16 17:49 ` [PATCH 07/15] io_uring: support for IO polling Jens Axboe
2019-01-16 17:49 ` [PATCH 08/15] fs: add fget_many() and fput_many() Jens Axboe
2019-01-16 17:49 ` [PATCH 09/15] io_uring: use fget/fput_many() for file references Jens Axboe
2019-01-16 17:49 ` [PATCH 10/15] io_uring: batch io_kiocb allocation Jens Axboe
2019-01-16 17:49 ` [PATCH 11/15] block: implement bio helper to add iter bvec pages to bio Jens Axboe
2019-01-16 17:50 ` [PATCH 12/15] io_uring: add support for pre-mapped user IO buffers Jens Axboe
2019-01-16 20:53 ` Dave Chinner
2019-01-16 21:20 ` Jens Axboe
2019-01-16 22:09 ` Dave Chinner
2019-01-16 22:21 ` Jens Axboe
2019-01-16 23:09 ` Dave Chinner
2019-01-16 23:17 ` Jens Axboe
2019-01-16 22:13 ` Jens Axboe
2019-01-16 17:50 ` [PATCH 13/15] io_uring: add submission polling Jens Axboe
2019-01-16 17:50 ` [PATCH 14/15] io_uring: add file registration Jens Axboe
2019-01-16 17:50 ` [PATCH 15/15] io_uring: add io_uring_event cache hit information Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2019-01-10 2:43 [PATCHSET v2] io_uring IO interface Jens Axboe
2019-01-10 2:43 ` [PATCH 05/15] Add " Jens Axboe
2019-01-11 18:19 ` Martin K. Petersen
2019-01-11 18:34 ` Jens Axboe
2019-01-13 16:22 ` Jens Axboe
2019-01-15 17:31 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49bm4f831e.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-block-owner@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpenyaev@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).